From b2e6999f9b527586a64064b0eebbee5cc6469f81 Mon Sep 17 00:00:00 2001 From: Vaidah Date: Sat, 17 Oct 2026 17:42:10 +0200 Subject: [PATCH 1/2] remove dead code from exercises --- dead-code/exercise-1.js | 10 ++-------- dead-code/exercise-2.js | 10 +--------- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 4d09f15fa9..2309c5d729 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,17 +1,11 @@ -// Find the instances of unreachable and redundant code - remove them! -// The sayHello function should continue to work for any reasonable input it's given. - -let testName = "Jerry"; const greeting = "hello"; function sayHello(greeting, name) { - const greetingStr = greeting + ", " + name + "!"; return `${greeting}, ${name}!`; - console.log(greetingStr); } -testName = "Aman"; +let testName = "Aman"; const greetingMessage = sayHello(greeting, testName); -console.log(greetingMessage); // 'hello, Aman!' +console.log(greetingMessage); diff --git a/dead-code/exercise-2.js b/dead-code/exercise-2.js index 56d7887c4c..7ecb955f24 100644 --- a/dead-code/exercise-2.js +++ b/dead-code/exercise-2.js @@ -1,14 +1,6 @@ -// Remove the unused code that does not contribute to the final console log -// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. - const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; -const capitalisedPets = pets.map((pet) => pet.toUpperCase()); const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); -function logPets(petsArr) { - petsArr.forEach((pet) => console.log(pet)); -} - function countAndCapitalisePets(petsArr) { const petCount = {}; @@ -25,4 +17,4 @@ function countAndCapitalisePets(petsArr) { const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH); -console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log +console.log(countedPetsStartingWithH); From 292cf271a537fd87e0a21fa9177de02bb4539981 Mon Sep 17 00:00:00 2001 From: Vaidah Date: Thu, 22 Oct 2026 01:26:56 +0200 Subject: [PATCH 2/2] fix variable shadowing and use const per reviewer feedback --- dead-code/exercise-1.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 2309c5d729..04a18bb2ac 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,11 +1,9 @@ -const greeting = "hello"; +let testName = "Aman"; function sayHello(greeting, name) { return `${greeting}, ${name}!`; } -let testName = "Aman"; - -const greetingMessage = sayHello(greeting, testName); +const greetingMessage = sayHello("hello", testName); console.log(greetingMessage);