From e0b177cb3fc7ba1dea93d3a8231f4568c8c1e84e Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Mon, 26 Oct 2026 18:03:43 -0700 Subject: [PATCH] feat: default enable_multi_writes to true Tracks LadybugDB/ladybug#1435, which renames debug_enable_multi_writes to enable_multi_writes and flips the engine default to true. Mirror that default here so the binding does not silently pin single-writer mode. --- src_cpp/py_database.cpp | 2 +- src_py/_lbug_capi.py | 2 +- src_py/database.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src_cpp/py_database.cpp b/src_cpp/py_database.cpp index 8281610..0c6340d 100644 --- a/src_cpp/py_database.cpp +++ b/src_cpp/py_database.cpp @@ -20,7 +20,7 @@ void PyDatabase::initialize(py::handle& m) { py::arg("read_only") = false, py::arg("max_db_size") = -1u, py::arg("auto_checkpoint") = true, py::arg("checkpoint_threshold") = -1, py::arg("throw_on_wal_replay_failure") = true, py::arg("enable_checksums") = true, - py::arg("enable_multi_writes") = false) + py::arg("enable_multi_writes") = true) .def("scan_node_table_as_int64", &PyDatabase::scanNodeTable, py::arg("table_name"), py::arg("prop_name"), py::arg("indices"), py::arg("np_array"), py::arg("num_threads")) diff --git a/src_py/_lbug_capi.py b/src_py/_lbug_capi.py index 95806a6..bf0324f 100644 --- a/src_py/_lbug_capi.py +++ b/src_py/_lbug_capi.py @@ -1206,7 +1206,7 @@ def __init__( checkpoint_threshold: int = -1, throw_on_wal_replay_failure: bool = True, enable_checksums: bool = True, - enable_multi_writes: bool = False, + enable_multi_writes: bool = True, ): self._database = _LbugDatabase() config = _LIB.lbug_default_system_config() diff --git a/src_py/database.py b/src_py/database.py index f0e2025..4c0a14c 100644 --- a/src_py/database.py +++ b/src_py/database.py @@ -44,7 +44,7 @@ def __init__( checkpoint_threshold: int = -1, throw_on_wal_replay_failure: bool = True, enable_checksums: bool = True, - enable_multi_writes: bool = False, + enable_multi_writes: bool = True, backend: str = "auto", ): """ @@ -101,7 +101,7 @@ def __init__( WAL file. enable_multi_writes: bool - If true, multiple concurrent write transactions are allowed. Default to False. + If true, multiple concurrent write transactions are allowed. Default to True. backend : {"auto", "capi", "pybind"} Backend to use for database/query execution.