- {{ art_row.ARTICLE_TITLE }}{% if art_row.CATEGORY %}
{{ art_row.CATEGORY }}{% endif %} |
+ {{ art_row.ARTICLE_TITLE }}{% if art_row.CATEGORY %}
{{ art_row.CATEGORY }}{% endif %}
{% INCLUDE '@phpbbmodders_knowledgebase/kb_list_status.html' %} |
{{ art_row.ARTICLE_AUTHOR }}
{{ art_row.ARTICLE_DATE }} |
{% if art_row.U_TOPIC %}
diff --git a/styles/all/theme/phpbbmodders_knowledgebase.css b/styles/all/theme/phpbbmodders_knowledgebase.css
index 64eaa59..a001f57 100644
--- a/styles/all/theme/phpbbmodders_knowledgebase.css
+++ b/styles/all/theme/phpbbmodders_knowledgebase.css
@@ -79,6 +79,19 @@ dd.action {
margin: 0;
}
+/* Separate article links from the author fields, including the final Topics row. */
+.kb-meta ~ .postbody .kb_codebox {
+ clear: both;
+ margin-top: 12px;
+}
+
+/* phpBB 4.0 code elements are inline; contain long article URLs on mobile. */
+.kb_codebox code {
+ display: block;
+ max-width: 100%;
+ overflow-x: auto;
+}
+
.kb_codebox input {
border: none;
color: #ffffff;
@@ -376,3 +389,20 @@ table.kb-index-table .kb-index-author {
padding: 0;
border-radius: 3px 3px 0 0;
}
+
+/* Keep title metadata together without clearing the floating author sidebar. */
+.kb-article-heading {
+ display: flow-root;
+ margin-right: 272px;
+}
+
+.kb-meta ~ .postbody .kb-article-heading h3 {
+ float: none;
+ margin-right: 0;
+}
+
+@media (max-width: 700px) {
+ .kb-article-heading {
+ margin-right: 0;
+ }
+}
diff --git a/tests/browser/kb_author_change.js b/tests/browser/kb_author_change.js
new file mode 100644
index 0000000..a59f51e
--- /dev/null
+++ b/tests/browser/kb_author_change.js
@@ -0,0 +1,140 @@
+// Run only on a disposable seed-forum board prepared for author-change checks.
+// KB_TEST_URL and KB_TEST_BOARD_ROOT are explicit; fixture passwords are public.
+const { chromium } = require('playwright');
+const { expect } = require('playwright/test');
+const { execFileSync } = require('node:child_process');
+const path = require('node:path');
+const fs = require('node:fs');
+const base = process.env.KB_TEST_URL;
+const root = process.env.KB_TEST_BOARD_ROOT;
+if (!base || !root || !root.includes('/seeded-board/kb-author-change-')) {
+ throw new Error('Set the disposable author-change board URL and root');
+}
+const fixture = path.join(__dirname, 'kb_author_change_fixture.py');
+function data(operation) {
+ return JSON.parse(execFileSync('python3', [fixture, root, operation], { encoding: 'utf8' }));
+}
+async function ready(page) {
+ await page.waitForFunction(() => {
+ const input = document.querySelector('input[name="creation_time"]');
+ return !input || Math.floor(Date.now() / 1000) > Number(input.value) + 1;
+ });
+}
+(async () => {
+ const before = data('prepare');
+ const browser = await chromium.launch({ headless: !process.env.DISPLAY });
+ const contexts = [];
+ let checks = 0;
+ const errors = [];
+ const url = id => `${base}/knowledgebase/change_author?k=${id}`;
+ async function login(name) {
+ const context = await browser.newContext();
+ contexts.push(context);
+ const page = await context.newPage();
+ page.on('pageerror', error => errors.push(error.message));
+ await page.goto(`${base}/ucp.php?mode=login`);
+ await page.locator('#username').fill(name);
+ await page.locator('#password').fill('KbTest1234!');
+ await ready(page);
+ await page.locator('[name="login"][type="submit"]').click();
+ await page.waitForURL(value => !value.search.includes('mode=login'), { timeout: 10000 }).catch(async error => { console.error(name, await page.locator('body').innerText()); throw error; });
+ return page;
+ }
+ async function status(page, id, expected) {
+ expect((await page.goto(url(id))).status()).toBe(expected);
+ checks++;
+ }
+ async function transfer(page, type, value) {
+ await page.goto(url(2));
+ await page.locator('#author_type').selectOption(String(type));
+ if (type === 0) await page.locator('#username').fill(value);
+ else await page.locator('#group_id').selectOption(String(value));
+ await ready(page);
+ await page.getByRole('button', { name: 'Change author', exact: true }).click();
+ await expect(page).toHaveURL(/knowledgebase\/article\?k=2/);
+ checks++;
+ }
+ try {
+ const guest = await browser.newPage();
+ await status(guest, 2, 403);
+ const reader = await login('kb_reader');
+ await status(reader, 2, 403);
+ const original = await login('kb_author1');
+ await status(original, 2, 403);
+ const moderator = await login('kb_transfer_moderator');
+ await status(moderator, 2, 200);
+ await status(moderator, 4, 403);
+ const admin = await login('admin');
+ await status(admin, 11, 404);
+ await status(admin, 1, 409);
+ await expect(admin.locator('.kb-notice')).toContainText('Authorship cannot be transferred');
+ await expect(admin.locator('.kb-tabs')).toContainText('Notice');
+ checks++;
+ await admin.goto(`${base}/knowledgebase/article?k=1`);
+ await expect(admin.locator('.kb-article-status')).toContainText('Has draft');
+ await reader.goto(`${base}/knowledgebase/article?k=1`);
+ await expect(reader.locator('.kb-article-status')).not.toContainText('Has draft');
+ checks++;
+ await admin.goto(`${base}/knowledgebase/category?id=${before.article.article_category_id}`);
+ await expect(admin.locator('tr[id="2"] .kb-article-status')).toContainText('Revision pending');
+ checks++;
+
+ await admin.goto(url(2));
+ await expect(admin.getByRole('heading', { name: 'Change author', exact: true })).toBeVisible();
+ checks++;
+ const form = await admin.locator('form[action*="change_author"]').evaluate(form => Object.fromEntries(new FormData(form)));
+ const forged = await admin.request.post(url(2), { form: { ...form, submit: 'Change author', username: 'kb_author2', form_token: 'invalid' } });
+ expect(await forged.text()).toContain('The submitted form was invalid');
+ expect(data('snapshot').article.author_id).toBe(before.article.author_id);
+ checks++;
+ await admin.locator('#username').fill('nonexistent_fixture_account');
+ await ready(admin);
+ await admin.getByRole('button', { name: 'Change author', exact: true }).click();
+ await expect(admin.getByText('Choose an active member or a configured Knowledge Base team.', { exact: true })).toBeVisible();
+ checks++;
+ await admin.goto(url(2));
+ await admin.locator('#username').fill('kb_author2');
+ await admin.locator('[name="old_author_id"]').evaluate(input => input.value = '999999');
+ await ready(admin);
+ await admin.getByRole('button', { name: 'Change author', exact: true }).click();
+ await expect(admin.getByText(/The author or article status changed/)).toBeVisible();
+ checks++;
+ await transfer(moderator, 0, 'kb_author2');
+ let after = data('snapshot');
+ expect(after.article.author_id).toBe(before.target_user);
+ expect(after.article.author_type).toBe(0);
+ expect(after.revisions).toEqual(before.revisions);
+ expect(after.coauthors).toEqual(before.coauthors.filter(row => !(row.author_type === 0 && row.author_ref_id === before.target_user)));
+ for (const key of Object.keys(before.article).filter(key => !['author_id', 'author_type', 'author', 'views'].includes(key))) {
+ expect(after.article[key], key).toEqual(before.article[key]);
+ }
+ checks++;
+ await original.goto(`${base}/knowledgebase/article?k=2`);
+ await expect(original.getByRole('link', { name: 'Edit', exact: true })).toHaveCount(0);
+ const newAuthor = await login('kb_author2');
+ await newAuthor.goto(`${base}/knowledgebase/article?k=2`);
+ await expect(newAuthor.getByRole('link', { name: 'Edit', exact: true })).toBeVisible();
+ checks++;
+ await transfer(admin, 1, before.team_id);
+ expect(data('snapshot').article.author_type).toBe(1);
+ checks++;
+ const output = process.env.KB_ARTIFACT_DIR;
+ if (output) {
+ fs.mkdirSync(output, { recursive: true });
+ await admin.goto(url(2));
+ await admin.screenshot({ path: path.join(output, 'change-author.png'), fullPage: true });
+ }
+ await transfer(admin, 0, 'kb_author1');
+ after = data('snapshot');
+ expect(after.article.author_id).toBe(before.article.author_id);
+ expect(after.revisions).toEqual(before.revisions);
+ expect(after.logs).toBe(before.logs + 3);
+ expect(errors).toEqual([]);
+ checks++;
+ console.log(JSON.stringify({ base, checks, result: 'PASS' }));
+ } finally {
+ data('restore');
+ for (const context of contexts) await context.close();
+ await browser.close();
+ }
+})();
diff --git a/tests/browser/kb_author_change_fixture.py b/tests/browser/kb_author_change_fixture.py
new file mode 100644
index 0000000..b01a8dd
--- /dev/null
+++ b/tests/browser/kb_author_change_fixture.py
@@ -0,0 +1,113 @@
+#!/usr/bin/env python3
+"""Prepare and restore author-change fixtures on a seeded SQLite board."""
+
+import json
+import pathlib
+import sqlite3
+import sys
+
+root = pathlib.Path(sys.argv[1]).resolve()
+operation = sys.argv[2]
+if "/seeded-board/kb-author-change-" not in str(root):
+ raise SystemExit("Not a disposable author-change fixture board")
+if not (root / ".seed-forum-seeds.json").is_file():
+ raise SystemExit("Board must be built through seed-forum")
+db = sqlite3.connect(root / "store/sqlite.db")
+db.row_factory = sqlite3.Row
+saved = root / "store/author-change-test-snapshot.json"
+
+
+def rows(sql, parameters=()):
+ """Read rows as dictionaries for deterministic preservation checks."""
+ return [dict(row) for row in db.execute(sql, parameters)]
+
+
+def snapshot():
+ """Read the article, its revision, co-authors, and audit-entry count."""
+ return {
+ "article": rows("SELECT * FROM phpbb_kb_articles WHERE article_id=2")[
+ 0
+ ],
+ "revisions": rows(
+ "SELECT * FROM phpbb_kb_article_revisions WHERE article_id=2"
+ ),
+ "coauthors": rows(
+ (
+ "SELECT * FROM phpbb_kb_article_co_authors WHERE article_id=2"
+ " ORDER BY author_type,author_ref_id"
+ )
+ ),
+ "logs": db.execute(
+ (
+ "SELECT COUNT(*) FROM phpbb_kb_log WHERE log_operation='LOG_L"
+ "IBRARY_CHANGED_AUTHOR'"
+ )
+ ).fetchone()[0],
+ }
+
+
+if operation == "prepare":
+ if saved.exists():
+ raise SystemExit(
+ "Restore the previous fixture run before preparing again"
+ )
+ original = snapshot()
+ moderator = db.execute(
+ "SELECT user_id FROM phpbb_users "
+ "WHERE username='kb_transfer_moderator'"
+ ).fetchone()
+ target = db.execute(
+ "SELECT user_id FROM phpbb_users WHERE username='kb_author2'"
+ ).fetchone()[0]
+ teams = [row["author_ref_id"] for row in original["coauthors"]
+ if row["author_type"] == 1]
+ if not moderator or not original["revisions"] or not teams:
+ raise SystemExit("Build the board with the updated KB seed script")
+ grant = db.execute(
+ "SELECT u.auth_setting FROM phpbb_kb_users u "
+ "JOIN phpbb_kb_options o ON o.auth_option_id=u.auth_option_id "
+ "WHERE u.user_id=? AND u.category_id=? "
+ "AND o.auth_option='kb_m_change_author'",
+ (moderator[0], original["article"]["article_category_id"]),
+ ).fetchone()
+ if not grant or grant[0] != 1:
+ raise SystemExit("The seed must grant scoped author-transfer access")
+ saved.write_text(json.dumps(original), encoding="utf-8")
+ result = original.copy()
+ result.update(target_user=target, team_id=teams[0])
+elif operation == "snapshot":
+ result = snapshot()
+elif operation == "restore":
+ original = json.loads(saved.read_text(encoding="utf-8"))
+ with db:
+ article = original["article"]
+ db.execute(
+ (
+ "UPDATE phpbb_kb_articles SET author_id=?,author_type=?,autho"
+ "r=? WHERE article_id=2"
+ ),
+ (article["author_id"], article["author_type"], article["author"]),
+ )
+ db.execute(
+ "DELETE FROM phpbb_kb_article_co_authors WHERE article_id=2"
+ )
+ for row in original["coauthors"]:
+ db.execute(
+ "INSERT INTO phpbb_kb_article_co_authors VALUES (?,?,?)",
+ tuple(row.values()),
+ )
+ with db:
+ db.execute("DELETE FROM phpbb_kb_article_revisions WHERE article_id=2")
+ for revision in original["revisions"]:
+ columns = ",".join(revision)
+ placeholders = ",".join("?" for _ in revision)
+ db.execute(
+ f"INSERT INTO phpbb_kb_article_revisions ({columns}) "
+ f"VALUES ({placeholders})",
+ tuple(revision.values()),
+ )
+ saved.unlink()
+ result = {"restored": True}
+else:
+ raise SystemExit("Use prepare, snapshot, or restore")
+print(json.dumps(result))
diff --git a/tests/browser/kb_layout_search.js b/tests/browser/kb_layout_search.js
new file mode 100644
index 0000000..6ba9e1e
--- /dev/null
+++ b/tests/browser/kb_layout_search.js
@@ -0,0 +1,43 @@
+const {chromium} = require('playwright');
+const {expect} = require('playwright/test');
+const fs = require('node:fs');
+const base = process.env.KB_TEST_URL;
+if (!/^http:\/\/localhost:810[01]$/.test(base || '')) throw new Error('Use the disposable KB preview URL');
+(async()=>{
+ const browser=await chromium.launch({headless:true});
+ const page=await browser.newPage({viewport:{width:1280,height:900}});
+ try {
+ await page.goto(`${base}/ucp.php?mode=login`);
+ await page.locator('#username').fill('admin');
+ await page.locator('#password').fill('KbTest1234!');
+ await page.waitForFunction(()=>Date.now()/1000>Number(document.querySelector('[name="creation_time"]').value)+2);
+ await page.locator('[name="login"][type="submit"]').click();
+ await page.waitForURL(url=>!url.search.includes('mode=login'));
+ await page.goto(`${base}/knowledgebase/article?k=2`);
+ const heading=page.locator('.kb-article-heading');
+ await expect(heading).toContainText('Description:');
+ await expect(heading).toContainText('Category:');
+ const titleBox=await heading.locator('h3').boundingBox();
+ const descriptionBox=await heading.locator('p').first().boundingBox();
+ expect(descriptionBox.y-titleBox.y-titleBox.height).toBeLessThan(25);
+ const out=process.env.KB_ARTIFACT_DIR;
+ fs.mkdirSync(out,{recursive:true});
+ await page.screenshot({path:`${out}/article-layout.png`,fullPage:true});
+ await page.setViewportSize({width:390,height:844});
+ await expect(heading).toBeVisible();
+ expect(await page.evaluate(()=>document.documentElement.scrollWidth<=window.innerWidth)).toBe(true);
+ await page.screenshot({path:`${out}/article-mobile.png`,fullPage:true});
+ await page.setViewportSize({width:1280,height:900});
+ await page.goto(`${base}/knowledgebase/queue`);
+ expect(await page.locator('.kb-article-status .kb-status-badge').count()).toBeGreaterThan(0);
+ await page.screenshot({path:`${out}/queue-statuses.png`,fullPage:true});
+ await page.goto(`${base}/knowledgebase/search?keywords=clean&sf=articles&cid=0`);
+ await expect(page.locator('.content').filter({hasText:'Clean URL Troubleshooting'}).first()).toBeVisible();
+ const results=page.locator('.content').filter({hasText:'Clean URL Troubleshooting'}).first();
+ expect(await results.locator('h1,h2,h3').count()).toBeGreaterThan(0);
+ expect(await results.innerText()).not.toContain('## Before you begin');
+ expect(await results.innerText()).not.toContain('# Clean URL Troubleshooting');
+ await page.screenshot({path:`${out}/markdown-search.png`,fullPage:true});
+ console.log(JSON.stringify({base,result:'PASS',checks:['metadata placement','mobile overflow','queue badges','rendered Markdown search']}));
+ } finally {await browser.close();}
+})();
diff --git a/tests/browser/kb_screenshot_config.php b/tests/browser/kb_screenshot_config.php
new file mode 100644
index 0000000..409975f
--- /dev/null
+++ b/tests/browser/kb_screenshot_config.php
@@ -0,0 +1,6 @@
+set('kb_hierarchical_index', (int) $argv[2]);
+echo $previous;
diff --git a/tests/browser/kb_screenshots.js b/tests/browser/kb_screenshots.js
new file mode 100644
index 0000000..8e6ebfb
--- /dev/null
+++ b/tests/browser/kb_screenshots.js
@@ -0,0 +1,72 @@
+// Capture only from the disposable board created through seed-forum.
+const {chromium}=require('playwright');
+const {expect}=require('playwright/test');
+const {execFileSync}=require('node:child_process');
+const fs=require('node:fs');
+const path=require('node:path');
+const base=process.env.KB_TEST_URL;
+const root=process.env.KB_TEST_BOARD_ROOT;
+const out=process.env.KB_ARTIFACT_DIR;
+const configHelper=process.env.KB_SCREENSHOT_CONFIG_HELPER;
+if(base!=='http://localhost:8102'||!root?.endsWith('/kb-author-change-seed-33')||!out||!configHelper)throw new Error('Use the explicit seed-forum screenshot fixture');
+function tree(value){return execFileSync('php',[configHelper,root,...(value===undefined?[]:[String(value)])],{encoding:'utf8'}).trim();}
+(async()=>{
+ const browser=await chromium.launch({headless:true});
+ const previous=tree();
+ fs.mkdirSync(out,{recursive:true});
+ const manifest=[];
+ async function login(name){
+ const context=await browser.newContext({viewport:{width:1440,height:1000},locale:'en-US'});
+ const page=await context.newPage();
+ await page.goto(`${base}/ucp.php?mode=login`);
+ await page.locator('#username').fill(name);
+ await page.locator('#password').fill('KbTest1234!');
+ await page.waitForFunction(()=>Date.now()/1000>Number(document.querySelector('[name="creation_time"]').value)+2);
+ await page.locator('[name="login"][type="submit"]').click();
+ await page.waitForURL(u=>!u.search.includes('mode=login'));
+ return page;
+ }
+ async function shot(page,name,url,selector,notice=false){
+ const response=await page.goto(`${base}/${url}`,{waitUntil:'networkidle'});
+ if(!response||response.status()>=400&&!(notice&&response.status()===409))throw new Error(`${name}: HTTP ${response?.status()}`);
+ await expect(page.locator(selector).first()).toBeVisible();
+ if(await page.locator('body').innerText().then(t=>/Fatal error:|General Error|Parse error:/.test(t)))throw new Error(`${name}: error page`);
+ await page.screenshot({path:path.join(out,name+'.png'),fullPage:true});
+ manifest.push({name,url});console.log('Saved '+name);
+ }
+ try{
+ const admin=await login('admin');
+ const author=await login('kb_author1');
+ if(!process.env.KB_SCREENSHOTS_ACP_ONLY){
+ tree(0);
+ await shot(admin,'01-flat-index','knowledgebase','table.kb-index-table');
+ await shot(admin,'02-article','knowledgebase/article?k=1','.kb-article-heading');
+ await shot(author,'03-manage-your-articles','knowledgebase/my_articles','table');
+ await shot(admin,'04-add-article','knowledgebase/posting?id=1','#postform');
+ await shot(admin,'05-approval-queue','knowledgebase/queue','table');
+ await shot(admin,'06-search-results','knowledgebase/search?keywords=backup','.content');
+ await shot(admin,'09-board-search-kb-block','search.php?keywords=backup','#page-body');
+ await shot(admin,'10-advanced-search-option','search.php','#kb_also');
+ await shot(admin,'12-recent-changes','knowledgebase/recent_changes','#page-body');
+ await shot(admin,'13-submit-redirect','knowledgebase/posting?id=1&mode=redirect','#postform');
+ await shot(admin,'14-change-author','knowledgebase/change_author?k=2','form[action*="change_author"]');
+ await shot(admin,'15-private-draft-notice','knowledgebase/change_author?k=1','.kb-notice',true);
+ await shot(admin,'16-markdown-search','knowledgebase/search?keywords=clean&sf=articles&cid=0','.content');
+ tree(1);
+ await shot(admin,'08-category-tree','knowledgebase','#page-body');
+ }
+ let sid=(await admin.context().cookies()).find(c=>c.name.endsWith('_sid')).value;
+ await admin.goto(`${base}/adm/index.php?sid=${sid}`);
+ if(await admin.locator('input[type="password"]').count()){
+ await admin.locator('input[type="password"]').fill('KbTest1234!');
+ await admin.waitForFunction(()=>{const e=document.querySelector('[name="creation_time"]');return !e||Date.now()/1000>Number(e.value)+2;});
+ await admin.locator('[name="login"][type="submit"]').click();
+ }
+ if(await admin.getByRole('link',{name:/Proceed to the ACP/}).count())await admin.getByRole('link',{name:/Proceed to the ACP/}).click();
+ sid=(await admin.context().cookies()).find(c=>c.name.endsWith('_sid')).value;
+ await shot(admin,'07-acp-configuration',`adm/index.php?i=-phpbbmodders-knowledgebase-acp-config_module&mode=settings&sid=${sid}`,'#acp');
+ await shot(admin,'11-acp-search-settings',`adm/index.php?i=-phpbbmodders-knowledgebase-acp-search_module&mode=index&sid=${sid}`,'#acp');
+ if(process.env.KB_SCREENSHOT_MANIFEST)fs.writeFileSync(process.env.KB_SCREENSHOT_MANIFEST,JSON.stringify(manifest.map(item=>({...item,url:item.url.replace(/([?&])sid=[^&]+/g,'$1').replace(/[?&]$/,'')})),null,2)+'\n');
+ console.log(JSON.stringify({result:'PASS',screenshots:manifest.length}));
+ }finally{tree(previous);await browser.close();}
+})();
diff --git a/tests/kb_article_text_test.php b/tests/kb_article_text_test.php
index 7194b41..da6d46b 100644
--- a/tests/kb_article_text_test.php
+++ b/tests/kb_article_text_test.php
@@ -109,6 +109,32 @@ public function test_the_renderer_setting_is_restored_even_if_rendering_fails()
}
}
+ public function test_markdown_search_excerpt_keeps_formatting_and_closes_cut_elements()
+ {
+ $this->renderer->method('get_viewcensors')->willReturn(false);
+ $this->renderer->method('render')->willReturn('GuideRésumé & notes follow Hidden tail ');
+ $html = $this->article_text->search_display('stored Markdown', '', 13);
+ $this->assertStringContainsString('Guide', $html);
+ $this->assertStringContainsString('Résumé &…', $html);
+ $this->assertStringNotContainsString('Hidden tail', $html);
+ }
+
+ public function test_unlimited_markdown_search_renders_the_stored_article()
+ {
+ $this->renderer->method('get_viewcensors')->willReturn(false);
+ $this->renderer->expects($this->once())->method('render')->with('stored')->willReturn('Title- Step
');
+ $this->assertSame('Title- Step
', $this->article_text->search_display('stored', '', -1));
+ }
+
+ public function test_markdown_excerpt_preserves_escaped_text_instead_of_creating_html()
+ {
+ $this->renderer->method('get_viewcensors')->willReturn(false);
+ $this->renderer->method('render')->willReturn('<script>alert(1)</script> ');
+ $html = $this->article_text->search_display('stored', '', 12);
+ $this->assertStringNotContainsString('assertStringContainsString('<script>', $html);
+ }
+
public function test_editing_a_markdown_article_gives_back_the_source_escaped_for_a_textarea()
{
$this->utils->expects($this->once())->method('unparse')->with('x')->willReturn("**x** < y & \"z\"");
diff --git a/tests/kb_author_change_controller_test.php b/tests/kb_author_change_controller_test.php
new file mode 100644
index 0000000..6cc3f57
--- /dev/null
+++ b/tests/kb_author_change_controller_test.php
@@ -0,0 +1,69 @@
+controller($user_id, $view, $permission, $status, $draft_edit);
+ $this->assertSame($expected, $controller->main()->getStatusCode());
+ }
+
+ public function access_cases(): array
+ {
+ return [
+ 'guest' => [1, true, true, 2, false, 403],
+ 'no KB access' => [2, false, true, 2, false, 403],
+ 'no transfer permission' => [2, true, false, 2, false, 403],
+ 'private draft' => [2, true, true, 4, false, 404],
+ 'private draft edit' => [2, true, true, 2, true, 409],
+ ];
+ }
+
+ public function test_invalid_csrf_cannot_call_transfer(): void
+ {
+ $controller = $this->controller(2, true, true, 2, false, true);
+ $response = $controller->main();
+ $this->assertSame(200, $response->getStatusCode());
+ $this->assertStringContainsString('FORM_INVALID', $response->getContent());
+ }
+
+ private function controller(int $user_id, bool $view, bool $permission, int $status, bool $draft_edit, bool $submit = false): change_author
+ {
+ $GLOBALS['kb_test_valid_forms'] = [];
+ $db = $this->createMock(\phpbb\db\driver\driver_interface::class);
+ $db->method('sql_fetchrow')->willReturn(['article_id' => 1, 'article_category_id' => 1, 'author_id' => 3, 'author_type' => 0, 'author' => 'Author', 'article_title' => 'Guide', 'status' => $status]);
+ $auth = $this->createMock(\phpbb\auth\auth::class);
+ $auth->method('acl_get')->willReturnCallback(fn($permission) => $view && $permission === 'u_kb_view');
+ $request = $this->createMock(\phpbb\request\request_interface::class);
+ $request->method('variable')->willReturnCallback(fn($name, $default) => ['k' => 1, 'old_author_id' => 3, 'old_author_type' => 0][$name] ?? $default);
+ $request->method('is_set_post')->willReturn($submit);
+ $kb = $this->createMock(\phpbbmodders\knowledgebase\inc\functions_kb::class);
+ $kb->method('get_article_categories')->willReturn([1]);
+ $kb->method('acl_kb_get_any')->willReturn($permission);
+ $kb->method('article_has_draft_edit')->willReturn($draft_edit);
+ $kb->method('get_kb_team_group_names')->willReturn([]);
+ $kb->method('get_author_display')->willReturn('Author');
+ $transfer = $this->createMock(\phpbbmodders\knowledgebase\inc\author_change::class);
+ $transfer->expects($this->never())->method('transfer');
+ $user = $this->createMock(\phpbb\user::class);
+ $user->data = ['user_id' => $user_id];
+ $lang = $this->createMock(\phpbb\language\language::class);
+ $lang->method('lang')->willReturnArgument(0);
+ $template = $this->createMock(\phpbb\template\template::class);
+ $errors = '';
+ $template->method('assign_vars')->willReturnCallback(function ($values) use (&$errors) { $errors = $values['ERROR'] ?? $values['NOTICE_MESSAGE'] ?? ''; });
+ $helper = $this->createMock(\phpbb\controller\helper::class);
+ $helper->method('route')->willReturn('/knowledgebase/article?k=1');
+ $helper->method('render')->willReturnCallback(function ($file, $title, $status = 200) use (&$errors) { return new \Symfony\Component\HttpFoundation\Response($errors, $status); });
+ return new change_author($db, $helper, $lang, $auth, $request, $template, $user, $kb, $transfer, 'articles');
+ }
+}
diff --git a/tests/kb_author_change_database_test.php b/tests/kb_author_change_database_test.php
new file mode 100644
index 0000000..1b4f545
--- /dev/null
+++ b/tests/kb_author_change_database_test.php
@@ -0,0 +1,89 @@
+markTestSkipped('Set the disposable kb_fixture database port');
+ }
+ $db = $engine === 'mysql' ? new \phpbb\db\driver\mysqli() : new \phpbb\db\driver\postgres();
+ $db->sql_connect('127.0.0.1', $engine === 'mysql' ? 'root' : 'postgres', '', 'kb_fixture', (int) $port);
+ $prefix = 'kb_author_test_';
+ $tables = ['articles', 'coauthors', 'drafts', 'results', 'kb_options', 'kb_users', 'kb_groups'];
+ try
+ {
+ foreach ($tables as $name) $db->sql_query('DROP TABLE IF EXISTS ' . $prefix . $name);
+ $db->sql_query('CREATE TABLE ' . $prefix . 'articles (article_id INTEGER PRIMARY KEY, author_id INTEGER, author_type INTEGER, author VARCHAR(255), article_title VARCHAR(255), status INTEGER)');
+ $db->sql_query("INSERT INTO " . $prefix . "articles VALUES (1, 2, 0, 'Original', 'Guide', 2)");
+ $db->sql_query('CREATE TABLE ' . $prefix . 'coauthors (article_id INTEGER, author_type INTEGER, author_ref_id INTEGER)');
+ $db->sql_query('INSERT INTO ' . $prefix . 'coauthors VALUES (1, 0, 3), (1, 0, 4)');
+ $db->sql_query('CREATE TABLE ' . $prefix . 'drafts (article_id INTEGER)');
+ $db->sql_query('CREATE TABLE ' . $prefix . 'results (search_key VARCHAR(32))');
+ $db->sql_query("INSERT INTO " . $prefix . "results VALUES ('cached-author')");
+ $cache = $this->createMock(\phpbb\cache\driver\driver_interface::class);
+ $cache->expects($this->once())->method('destroy')->with('_kb_search_results_cached-author');
+ $log = $this->createMock(\phpbb\log\log_interface::class);
+ $log->expects($this->once())->method('add')->willReturn(1);
+ $user = $this->createMock(\phpbb\user::class);
+ $user->data = ['user_id' => 9];
+ $user->ip = '127.0.0.1';
+ $service = new \phpbbmodders\knowledgebase\inc\author_change($db, $cache, $log, $user, $prefix . 'articles', $prefix . 'coauthors', $prefix . 'drafts', $prefix . 'results');
+ $result = $db->sql_query('SELECT * FROM ' . $prefix . 'articles');
+ $article = $db->sql_fetchrow($result);
+ $db->sql_freeresult($result);
+ $this->assertTrue($service->transfer($article, 3, 0, "O'Brien"));
+ $result = $db->sql_query('SELECT * FROM ' . $prefix . 'articles');
+ $row = $db->sql_fetchrow($result);
+ $db->sql_freeresult($result);
+ $this->assertSame(3, (int) $row['author_id']);
+ $this->assertSame("O'Brien", $row['author']);
+ $result = $db->sql_query('SELECT author_ref_id FROM ' . $prefix . 'coauthors');
+ $this->assertSame(4, (int) $db->sql_fetchfield('author_ref_id'));
+ $db->sql_freeresult($result);
+
+ // Run the permission migration on an existing options table, twice.
+ $identity = $engine === 'mysql' ? 'INTEGER AUTO_INCREMENT' : 'SERIAL';
+ $db->sql_query('CREATE TABLE ' . $prefix . 'kb_options (auth_option_id ' . $identity . ' PRIMARY KEY, auth_option VARCHAR(50) UNIQUE, is_global INTEGER, is_local INTEGER)');
+ foreach (['kb_users', 'kb_groups'] as $table)
+ {
+ $db->sql_query('CREATE TABLE ' . $prefix . $table . ' (auth_option_id INTEGER)');
+ }
+ $db->sql_query("INSERT INTO " . $prefix . "kb_options (auth_option, is_global, is_local) VALUES ('kb_m_edit', 0, 1)");
+ $tools = $this->createMock(\phpbb\db\tools\tools_interface::class);
+ $migration = new \phpbbmodders\knowledgebase\migrations\version_2_0_30(new \phpbb\config\config([]), $db, $tools, '', 'php', $prefix, []);
+ $migration->add_permission();
+ $migration->add_permission();
+ $result = $db->sql_query("SELECT auth_option_id FROM " . $prefix . "kb_options WHERE auth_option='kb_m_change_author'");
+ $id = (int) $db->sql_fetchfield('auth_option_id');
+ $db->sql_freeresult($result);
+ $this->assertGreaterThan(0, $id);
+ foreach (['kb_users', 'kb_groups'] as $table) $db->sql_query('INSERT INTO ' . $prefix . $table . ' VALUES (' . $id . ')');
+ $migration->remove_permission();
+ $migration->remove_permission();
+ $result = $db->sql_query('SELECT auth_option FROM ' . $prefix . 'kb_options');
+ $this->assertSame('kb_m_edit', $db->sql_fetchfield('auth_option'));
+ $db->sql_freeresult($result);
+ }
+ finally
+ {
+ foreach ($tables as $name) $db->sql_query('DROP TABLE IF EXISTS ' . $prefix . $name);
+ $db->sql_close();
+ }
+ }
+
+ public function engines(): array
+ {
+ return [['mysql'], ['postgres']];
+ }
+}
diff --git a/tests/kb_author_change_test.php b/tests/kb_author_change_test.php
new file mode 100644
index 0000000..0b7ef71
--- /dev/null
+++ b/tests/kb_author_change_test.php
@@ -0,0 +1,144 @@
+pdo = new \PDO('sqlite::memory:');
+ $this->pdo->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
+ $this->pdo->exec('CREATE TABLE articles (article_id INTEGER PRIMARY KEY, author_id INTEGER, author_type INTEGER, author TEXT, article_title TEXT, status INTEGER, body TEXT, edited INTEGER)');
+ $this->pdo->exec("INSERT INTO articles VALUES (1, 2, 0, 'Original', 'Guide', 2, 'Keep content', 123)");
+ $this->pdo->exec('CREATE TABLE co_authors (article_id INTEGER, author_type INTEGER, author_ref_id INTEGER)');
+ $this->pdo->exec('INSERT INTO co_authors VALUES (1, 0, 3), (1, 0, 4), (1, 1, 5)');
+ $this->pdo->exec('CREATE TABLE drafts (article_id INTEGER, body TEXT)');
+ $this->pdo->exec('CREATE TABLE revisions (article_id INTEGER, submitted_by INTEGER, body TEXT)');
+ $this->pdo->exec("INSERT INTO revisions VALUES (1, 2, 'Pending revision')");
+ $this->pdo->exec('CREATE TABLE results (search_key TEXT)');
+ $this->pdo->exec("INSERT INTO results VALUES ('author-filter')");
+ $this->db = $this->createMock(\phpbb\db\driver\driver_interface::class);
+ $affected = 0;
+ $this->db->method('sql_query')->willReturnCallback(function ($sql) use (&$affected) {
+ $result = $this->pdo->query($sql);
+ $affected = $result->rowCount();
+ return $result;
+ });
+ $this->db->method('sql_affectedrows')->willReturnCallback(function () use (&$affected) { return $affected; });
+ $this->db->method('sql_fetchrow')->willReturnCallback(fn($result) => $result->fetch(\PDO::FETCH_ASSOC));
+ $this->db->method('sql_build_array')->willReturnCallback(function ($mode, $data) {
+ return implode(', ', array_map(fn($key) => $key . ' = ' . $this->pdo->quote((string) $data[$key]), array_keys($data)));
+ });
+ $this->db->method('sql_transaction')->willReturnCallback(function ($mode) {
+ return match ($mode) {
+ 'begin' => $this->pdo->beginTransaction(),
+ 'commit' => $this->pdo->commit(),
+ 'rollback' => $this->pdo->rollBack(),
+ };
+ });
+ $this->cache = $this->createMock(\phpbb\cache\driver\driver_interface::class);
+ $this->log = $this->createMock(\phpbb\log\log_interface::class);
+ $this->log->method('add')->willReturn(1);
+ $user = $this->createMock(\phpbb\user::class);
+ $user->data = ['user_id' => 9];
+ $user->ip = '127.0.0.1';
+ $this->service = new author_change($this->db, $this->cache, $this->log, $user, 'articles', 'co_authors', 'drafts', 'results');
+ }
+
+ private function article(): array
+ {
+ return $this->pdo->query('SELECT * FROM articles WHERE article_id = 1')->fetch(\PDO::FETCH_ASSOC);
+ }
+
+ public function test_transfer_preserves_content_revisions_and_unrelated_coauthors(): void
+ {
+ $before = $this->article();
+ $this->log->expects($this->once())->method('add')->with('admin', 9, '127.0.0.1', 'LOG_LIBRARY_CHANGED_AUTHOR', $this->anything(), ['Guide', 'Original (0:2)', 'New author (0:3)']);
+ $this->cache->expects($this->once())->method('destroy')->with('_kb_search_results_author-filter');
+ $this->assertTrue($this->service->transfer($before, 3, 0, 'New author'));
+ $after = $this->article();
+ $this->assertSame('New author', $after['author']);
+ $this->assertSame(3, $after['author_id']);
+ foreach (['body', 'edited', 'status'] as $field)
+ {
+ $this->assertSame($before[$field], $after[$field]);
+ }
+ $this->assertSame([4, 5], $this->pdo->query('SELECT author_ref_id FROM co_authors ORDER BY author_ref_id')->fetchAll(\PDO::FETCH_COLUMN));
+ $this->assertSame(['article_id' => 1, 'submitted_by' => 2, 'body' => 'Pending revision'], $this->pdo->query('SELECT * FROM revisions')->fetch(\PDO::FETCH_ASSOC));
+ }
+
+ public function test_team_transfer_does_not_remove_a_user_with_the_same_numeric_id(): void
+ {
+ $this->assertTrue($this->service->transfer($this->article(), 3, 1, 'Team'));
+ $this->assertSame(3, (int) $this->pdo->query('SELECT COUNT(*) FROM co_authors')->fetchColumn());
+ $this->assertSame(1, $this->article()['author_type']);
+ }
+
+ public function test_same_author_does_not_log_or_write(): void
+ {
+ $this->log->expects($this->never())->method('add');
+ $this->db->expects($this->never())->method('sql_query');
+ $this->assertFalse($this->service->transfer($this->article(), 2, 0, 'Original'));
+ }
+
+ public function test_private_draft_edit_blocks_transfer(): void
+ {
+ $this->pdo->exec("INSERT INTO drafts VALUES (1, 'Private content')");
+ $this->log->expects($this->never())->method('add');
+ try
+ {
+ $this->service->transfer($this->article(), 3, 0, 'New');
+ $this->fail('A private draft edit must not transfer');
+ }
+ catch (\RuntimeException $error)
+ {
+ $this->assertSame('KB_CHANGE_AUTHOR_CONFLICT', $error->getMessage());
+ }
+ $this->assertSame(2, $this->article()['author_id']);
+ $this->assertSame(3, (int) $this->pdo->query('SELECT COUNT(*) FROM co_authors')->fetchColumn());
+ }
+
+ public function test_stale_owner_does_not_overwrite_another_transfer(): void
+ {
+ $before = $this->article();
+ $this->pdo->exec('UPDATE articles SET author_id = 7');
+ $this->expectExceptionMessage('KB_CHANGE_AUTHOR_CONFLICT');
+ $this->service->transfer($before, 3, 0, 'New');
+ }
+
+ public function test_log_failure_rolls_back_the_author_and_coauthors(): void
+ {
+ $this->log->method('add')->willThrowException(new \RuntimeException('Log unavailable'));
+ try
+ {
+ $this->service->transfer($this->article(), 3, 0, 'New');
+ $this->fail('Log failure must be visible');
+ }
+ catch (\RuntimeException $error)
+ {
+ $this->assertSame('Log unavailable', $error->getMessage());
+ }
+ $this->assertSame(2, $this->article()['author_id']);
+ $this->assertSame(3, (int) $this->pdo->query('SELECT COUNT(*) FROM co_authors')->fetchColumn());
+ }
+
+ public function test_private_draft_article_is_rejected(): void
+ {
+ $this->pdo->exec('UPDATE articles SET status = ' . functions_kb::STATUS_DRAFT);
+ $this->expectExceptionMessage('KB_CHANGE_AUTHOR_PRIVATE_DRAFT');
+ $this->service->transfer($this->article(), 3, 0, 'New');
+ }
+}
diff --git a/textformatter/article_text.php b/textformatter/article_text.php
index df6a265..52c6ba5 100644
--- a/textformatter/article_text.php
+++ b/textformatter/article_text.php
@@ -114,6 +114,60 @@ public function display(string $stored, string $uid, bool $markdown, bool $censo
}
}
+ /** Render a Markdown search excerpt without cutting stored XML or HTML tags. */
+ public function search_display(string $stored, string $uid, int $length): string
+ {
+ $html = $this->display($stored, $uid, true, false);
+ if ($length <= 0)
+ {
+ return $html;
+ }
+ $document = new \DOMDocument('1.0', 'UTF-8');
+ $previous_errors = libxml_use_internal_errors(true);
+ try
+ {
+ $document->loadHTML('' . $html . ' ', LIBXML_HTML_NOIMPLIED | LIBXML_HTML_NODEFDTD);
+ }
+ finally
+ {
+ libxml_clear_errors();
+ libxml_use_internal_errors($previous_errors);
+ }
+ $root = $document->getElementById('kb-search-excerpt');
+ $remaining = $length;
+ $trim = function (\DOMNode $node) use (&$trim, &$remaining): void
+ {
+ foreach (iterator_to_array($node->childNodes) as $child)
+ {
+ if ($remaining <= 0)
+ {
+ $node->removeChild($child);
+ }
+ else if ($child instanceof \DOMText)
+ {
+ $text = $child->nodeValue;
+ $size = utf8_strlen($text);
+ if ($size > $remaining)
+ {
+ $child->nodeValue = utf8_substr($text, 0, $remaining) . '…';
+ }
+ $remaining -= $size;
+ }
+ else
+ {
+ $trim($child);
+ }
+ }
+ };
+ $trim($root);
+ $result = '';
+ foreach ($root->childNodes as $child)
+ {
+ $result .= $document->saveHTML($child);
+ }
+ return $result;
+ }
+
/**
* Turn stored Markdown text back into what the author typed, escaped for
* use inside a textarea.
|
## Hierarchical category browsing
The category tree with its subcategories, article counts and the last article of each.
-
+
## An article
-The article with its status, details, a copyable link and BBCode, and the tab that reads "Reading Article #1".
+The article with its status, details, a copyable link and BBCode, and the tab that reads "Reading Article #1", with the private-draft indicator visible to the administrator.
-
+
## Manage your articles
A member's own articles and drafts.
-
+
## Recent changes
The **Recent changes** tab: the live articles, newest first, with a **New** or **Updated** badge, the category, the author and when the article last changed. Under the heading are the RSS and Atom feeds of the same list. A browser or feed reader also finds them from the page header, and the ACP says which formats are offered.
-
+
## Add an article
The form for a new article.
-
+
## The approval queue
The Administration tab: new articles and revisions waiting for review, with the actions available to a moderator.
-
+
## Search
Results of a search on the Knowledge Base's own search page.
-
+
## ACP configuration
**Extensions > Knowledge Base > Configuration**, the whole page: the announcement and changelog forums, hierarchical browsing, the alternative stylesheet, the **Recent changes feed** (RSS, Atom or both), the number of articles per page, the description length and the sorting order, then the attachment settings, the review teams and the contact group.
-
+
## Knowledge Base articles in the board's search
A search in phpBB's own search for `backup`. The **Knowledge Base (4)** block sits above the forum results and lists the best matches with their category, a snippet with the word marked and a link to all of them; the forum post that asks about backups is the first of the forum results below it. Switch the block off, or set how many articles it lists, in the ACP.
-
+
## Also search the Knowledge Base
The advanced search has an **Also search the Knowledge Base** option, ticked by default.
-
+
## ACP search settings
**Extensions > Knowledge Base > Search**: under **General search settings**, whether the board search shows the Knowledge Base block and how many articles it lists, beside the results per page for the Knowledge Base's own search; then the search backend and each backend's index.
-
+
+
+
+## Submit a redirect
+
+The redirect form, with its visible Knowledge Base » Submit a Redirect heading.
+
+
+
+## Change author
+
+Transfer the primary author to an active member or configured KB team while retaining the pending revision.
+
+
+
+## Private draft Notice
+
+A blocked transfer appears in the extension's Notice tab, with the board styling and navigation intact.
+
+
+
+## Rendered Markdown search
+
+Markdown headings, lists and emphasis render in a shortened search excerpt rather than appearing as source syntax.
+
diff --git a/docs/testing.md b/docs/testing.md
index 6395c09..97072be 100644
--- a/docs/testing.md
+++ b/docs/testing.md
@@ -1357,3 +1357,34 @@ a guest getting 403 until guests may read and then both feeds and the page, a me
`kb_feed_test.php` (the wiki's feed cases: formats offered, valid settings, both documents well formed with values escaped once, an empty feed) and `kb_recent_changes_test.php` (the migration; 403 without running a query, 404 for a format not offered, the feed built from given rows with its headers and New or Updated summaries, the query's live-only
conditions and ordering, and the routes, service, tab, header template, ACP and language strings being wired in) are new; the style layout test now expects the extra tab. The suite passes with 485 tests (17 skipped: database cases without the MySQL and PostgreSQL fixtures, which this change does not touch).
+
+
+## Primary author transfers
+
+The author-transfer tests cover permission checks, CSRF rejection, private
+article and edit drafts, stale ownership, member/team transfers, co-author
+handling, audit logging and rollback, and search-result cache invalidation.
+Run `kb_author_change_database_test.php` with the disposable database ports
+above to exercise the actual MySQL and PostgreSQL transfer SQL and permission
+migration/rollback.
+
+The browser check uses the standard seed-forum fixtures on a dedicated SQLite
+board whose directory is named `kb-author-change-*` under `seeded-board/`.
+It temporarily grants the `forum_moderator` account transfer permission for
+one category, prepares a pending revision and co-authors, and restores those
+fixtures after the checks. The audit entries remain as test evidence.
+
+```bash
+KB_TEST_URL=http://localhost:8100 \
+KB_TEST_BOARD_ROOT=/path/to/seeded-board/kb-author-change-33 \
+node /path/to/playwright-skill/run.js tests/browser/kb_author_change.js
+```
+
+`KB_ARTIFACT_DIR` optionally selects a directory for a full-page form screenshot.
+Use only disposable fixture boards: these checks change article ownership
+through real browser sessions before restoring it.
+
+The canonical seed-forum `bin/seed-kb-fixtures.php` supplies the author-transfer
+moderator, co-authors and pending revision. Build a fresh board with the updated
+script before running the browser suite. Its Python helper only snapshots and
+restores the fixture; it does not create articles or grant permissions.
diff --git a/docs/update/2026-10-18/01-change-author.png b/docs/update/2026-10-18/01-change-author.png
new file mode 100644
index 0000000..08115f7
Binary files /dev/null and b/docs/update/2026-10-18/01-change-author.png differ
diff --git a/docs/update/2026-10-18/02-queue-statuses.png b/docs/update/2026-10-18/02-queue-statuses.png
new file mode 100644
index 0000000..c611aea
Binary files /dev/null and b/docs/update/2026-10-18/02-queue-statuses.png differ
diff --git a/docs/update/2026-10-18/03-markdown-search.png b/docs/update/2026-10-18/03-markdown-search.png
new file mode 100644
index 0000000..84b150b
Binary files /dev/null and b/docs/update/2026-10-18/03-markdown-search.png differ
diff --git a/inc/author_change.php b/inc/author_change.php
new file mode 100644
index 0000000..28bf62a
--- /dev/null
+++ b/inc/author_change.php
@@ -0,0 +1,99 @@
+db->sql_transaction('begin');
+ try
+ {
+ $sql = 'UPDATE ' . $this->articles_table . ' SET ' . $this->db->sql_build_array('UPDATE', [
+ 'author_id' => $author_id, 'author_type' => $author_type, 'author' => $author_name,
+ ]) . '
+ WHERE article_id = ' . $article_id . '
+ AND author_id = ' . (int) $article['author_id'] . '
+ AND author_type = ' . (int) $article['author_type'] . '
+ AND status = ' . (int) $article['status'] . '
+ AND NOT EXISTS (SELECT article_id FROM ' . $this->draft_edits_table . '
+ WHERE article_id = ' . $article_id . ')';
+ $this->db->sql_query($sql);
+ if (!$this->db->sql_affectedrows())
+ {
+ throw new \RuntimeException('KB_CHANGE_AUTHOR_CONFLICT');
+ }
+
+ // The new primary author must not also be listed as a co-author.
+ $this->db->sql_query('DELETE FROM ' . $this->co_authors_table . '
+ WHERE article_id = ' . $article_id . '
+ AND author_type = ' . $author_type . '
+ AND author_ref_id = ' . $author_id);
+ $log_id = $this->log->add('admin', (int) $this->user->data['user_id'], $this->user->ip,
+ 'LOG_LIBRARY_CHANGED_AUTHOR', time(), [
+ $article['article_title'],
+ $article['author'] . ' (' . (int) $article['author_type'] . ':' . (int) $article['author_id'] . ')',
+ $author_name . ' (' . $author_type . ':' . $author_id . ')',
+ ]);
+ if (!$log_id)
+ {
+ throw new \RuntimeException('KB_CHANGE_AUTHOR_LOG_FAILED');
+ }
+ $this->db->sql_transaction('commit');
+ }
+ catch (\Throwable $error)
+ {
+ $this->db->sql_transaction('rollback');
+ throw $error;
+ }
+
+ // Author filters are cached separately from the full-text word index.
+ // Invalidate KB results only; their word matches need no rebuilding.
+ $result = $this->db->sql_query('SELECT search_key FROM ' . $this->search_results_table);
+ while ($row = $this->db->sql_fetchrow($result))
+ {
+ $this->cache->destroy('_kb_search_results_' . $row['search_key']);
+ }
+ $this->db->sql_freeresult($result);
+ return true;
+ }
+}
diff --git a/inc/functions_kb.php b/inc/functions_kb.php
index 65d92d8..b700018 100644
--- a/inc/functions_kb.php
+++ b/inc/functions_kb.php
@@ -1699,10 +1699,27 @@ public function delete_article_revision(int $article_id): void
$this->db->sql_query($sql);
}
- /**
- * @param int $article_id
- * @return bool
- */
+ /** Return pending revision and private draft existence flags for a page of articles. */
+ public function get_article_edit_flags_bulk(array $article_ids): array
+ {
+ $flags = [];
+ $article_ids = array_values(array_unique(array_map('intval', $article_ids)));
+ if (!$article_ids)
+ {
+ return $flags;
+ }
+ foreach (['revision' => $this->revisions_table, 'draft' => $this->draft_edits_table] as $flag => $table)
+ {
+ $result = $this->db->sql_query('SELECT article_id FROM ' . $table . ' WHERE ' . $this->db->sql_in_set('article_id', $article_ids));
+ while ($row = $this->db->sql_fetchrow($result))
+ {
+ $flags[(int) $row['article_id']][$flag] = true;
+ }
+ $this->db->sql_freeresult($result);
+ }
+ return $flags;
+ }
+
public function article_has_draft_edit(int $article_id): bool
{
return (bool) $this->get_article_draft_edit($article_id);
diff --git a/language/en/acp_knowledgebase.php b/language/en/acp_knowledgebase.php
index 1dd2277..cc508bc 100644
--- a/language/en/acp_knowledgebase.php
+++ b/language/en/acp_knowledgebase.php
@@ -158,6 +158,7 @@
'kb_u_delete' => 'Can delete own articles',
'kb_u_add_noapprove' => 'Can add / modify articles without prior approval',
// Moderator Permissions
+'kb_m_change_author' => 'Can change the primary author of submitted articles',
'kb_m_edit' => 'Can edit articles',
'kb_m_delete' => 'Can delete articles',
'kb_m_approve' => 'Can approve articles',
diff --git a/language/en/knowledgebase_lng.php b/language/en/knowledgebase_lng.php
index deeb942..b35ac84 100644
--- a/language/en/knowledgebase_lng.php
+++ b/language/en/knowledgebase_lng.php
@@ -18,10 +18,21 @@
}
$lang = array_merge($lang, [
+ 'KB_CHANGE_AUTHOR' => 'Change author',
+ 'KB_CHANGE_AUTHOR_TYPE' => 'New author type',
+ 'KB_CHANGE_AUTHOR_SELECT_TEAM' => 'Select a team',
+ 'KB_CHANGE_AUTHOR_TEAM' => 'Knowledge Base team',
+ 'KB_CHANGE_AUTHOR_EXPLAIN' => 'Choose a member or a Knowledge Base team as the new primary author. Use the field for the selected author type. Co-authors, article content, and submitted revisions are retained. This replaces the primary author; co-author and team permissions still apply.',
+ 'KB_CHANGE_AUTHOR_LOG_FAILED' => 'The author could not be changed because the audit log could not be written.',
+ 'KB_CHANGE_AUTHOR_INVALID' => 'Choose an active member or a configured Knowledge Base team.',
+ 'KB_CHANGE_AUTHOR_PRIVATE_DRAFT' => 'Authorship cannot be transferred while a private draft or private draft edit exists. Ask its author to submit or discard it first.',
+ 'KB_CHANGE_AUTHOR_CONFLICT' => 'The author or article status changed, or a private draft edit was saved. Reload the form before trying again.',
+ 'LOG_LIBRARY_CHANGED_AUTHOR' => 'Changed the author of article “%1$s”