diff --git a/pom.xml b/pom.xml index 69f2f5614c..35832e4fa7 100644 --- a/pom.xml +++ b/pom.xml @@ -477,7 +477,7 @@ com.google.errorprone error_prone_core - 2.50.0 + 2.51.0 com.uber.nullaway diff --git a/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java b/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java index 818f14416b..9472eeeba9 100644 --- a/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java +++ b/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java @@ -75,6 +75,6 @@ public boolean equals(Object o) { @Override public int hashCode() { - return Objects.hash(name); + return 31 + Objects.hashCode(name); } } diff --git a/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java b/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java index e288a2375a..17cfa12e09 100644 --- a/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java +++ b/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java @@ -43,4 +43,13 @@ void testEquals4() { assertThat(unit1).isEqualTo(unit2); } + + @Test + void testEqualUnitsHaveEqualHashCodes() { + Unit unit1 = new Unit(" bytes "); + Unit unit2 = new Unit("bytes"); + + assertThat(unit1).isEqualTo(unit2); + assertThat(unit1.hashCode()).isEqualTo(unit2.hashCode()); + } }