From 7498072d6b19e882fc648c9b49408bebe87fa154 Mon Sep 17 00:00:00 2001 From: 81reap Date: Thu, 29 Oct 2026 18:27:14 -0400 Subject: [PATCH] fix(table) :: show striped rows in dark mode Tabler 1.5.0 didn't show table stripes in dark mode. This was fixed in Tabler 1.7.3 (tabler/tabler#3279). So we upgraded and added tests. Fixes #957 Assisted-By :: Claude Opus 5.5 --- CHANGELOG.md | 2 ++ package-lock.json | 16 ++++++++++++---- package.json | 2 +- tests/end-to-end/component-assertions.ts | 3 ++- 4 files changed, 17 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 99547447..4e850bce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ - Now a tab with a `color` is underlined only when it is active. ([#791](https://github.com/sqlpage/SQLPage/issues/791)) +- Striped table rows are visible in dark mode again. Tabler was updated to [v1.7.3](https://github.com/tabler/tabler/releases/tag/%40tabler%2Fcore%401.7.3) to fix this. ([#957](https://github.com/sqlpage/SQLPage/issues/957)) + - Shell submenus stay open again when you click inside them. ([#1011](https://github.com/sqlpage/SQLPage/issues/1011)) - Refined the official website with muted blue accents, simpler navigation, a clearer primary action, and a level SQL ribbon with vertical separators, and a grounded studio scene with brushed metal and physical reflections. Restored visible progress in the streaming comparison animation. diff --git a/package-lock.json b/package-lock.json index 27c22280..2001d415 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,7 @@ "tests/end-to-end" ], "dependencies": { - "@tabler/core": "1.5.0", + "@tabler/core": "1.7.3", "@tabler/icons-sprite": "3.46.0", "apexcharts": "7.6.0", "tom-select": "2.6.2" @@ -502,9 +502,9 @@ "license": "MIT" }, "node_modules/@tabler/core": { - "version": "1.5.0", - "resolved": "https://registry.npmjs.org/@tabler/core/-/core-1.5.0.tgz", - "integrity": "sha512-nXFwOF0jlH6cH57eCRDI6uxhlQGtN92hBmkSwgIsUNg+hQBwnK9clAv3dEcSkVkXY+lKpDq8hpCvDT1AwPIzZw==", + "version": "1.7.3", + "resolved": "https://registry.npmjs.org/@tabler/core/-/core-1.7.3.tgz", + "integrity": "sha512-9PDS6U69svI987zIpd0AVLF4Gw9Uxfq1aypceVMNxye9Jp4QWYZEtzTL7z60L8qLyVQupHA+ug1AIA8gGAnYRA==", "license": "MIT", "dependencies": { "@popperjs/core": "^2.11.8" @@ -515,6 +515,14 @@ "funding": { "type": "github", "url": "https://github.com/sponsors/codecalm" + }, + "peerDependencies": { + "vanilla-calendar-pro": "^3.3.2" + }, + "peerDependenciesMeta": { + "vanilla-calendar-pro": { + "optional": true + } } }, "node_modules/@tabler/icons": { diff --git a/package.json b/package.json index a013f1db..8b4bba8d 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ }, "license": "MIT", "dependencies": { - "@tabler/core": "1.5.0", + "@tabler/core": "1.7.3", "@tabler/icons-sprite": "3.46.0", "apexcharts": "7.6.0", "tom-select": "2.6.2" diff --git a/tests/end-to-end/component-assertions.ts b/tests/end-to-end/component-assertions.ts index 65bc7219..0fbe327e 100644 --- a/tests/end-to-end/component-assertions.ts +++ b/tests/end-to-end/component-assertions.ts @@ -166,10 +166,11 @@ export async function checkToastNotifications(page: Page) { backgroundColor: rgba(style.backgroundColor), closeColor: rgba(closeStyle.backgroundColor), color: rgba(style.color), + themeDark: rgba(style.getPropertyValue("--tblr-dark")), }; }); expect(whiteToastStyle.backgroundColor).toEqual([255, 255, 255, 255]); - expect(whiteToastStyle.color).toEqual([31, 41, 55, 255]); + expect(whiteToastStyle.color).toEqual(whiteToastStyle.themeDark); expect(whiteToastStyle.closeColor).toEqual(whiteToastStyle.color); const bottomContainer = page.locator(