Repository navigation
fix(django): close automatically opened client after send failures - #39
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Django's Postmark backend leaves an automatically opened client attached after
send_batchraises or returns a failed message. The close call is only reached after every batch succeeds.Put the batch loop inside
try/finallyso clients opened bysend_messagesare closed on failure too. Keep this cleanup inside the existing exception-handling boundary sofail_silently, error signals, partial success counts, and caller-owned connection reuse remain intact. Add an Unreleased changelog entry.Fixes #38.
Validation
fail_silentlyvalues, and automatically opened versus caller-owned clients.pytest --cov=postmark --cov-report=term --cov-fail-under=85— 462 passed, 96.32% coverage.pre-commit run --all-files— all applicable hooks pass, including Poetry metadata/lock consistency, pinned Ruff/MyPy, codespell, Bandit, and secret scanning.git diff --checkpasses. No unrelated file changes.AI assistance: OpenAI Codex investigated, implemented, tested, and prepared this draft. Human verification is not claimed.