Repository navigation
Conversation
jpn--
self-requested a review
October 22, 2026 17:46
Member
|
@janzill will update this PR to accommodate changes to PnR |
…due to parking_choice updates. also fixes some edge cases and doc strings.
Contributor
Author
@jpn-- I've pushed my changes, it is ready for review. The PR touches many files, but quite a few of these are small consistency edits, most of which where caught by an LLM. This includes things like guarding against all choosers having no alternatives to sample from, which realistically only happens during testing and maybe for small-scale example models, addition of doc strings, and other small edge cases. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1129