Repository navigation
fix: avoid duplicate Stripe sale wiring during onboarding - #41
Merged
Merged
Conversation
…; sale snippets never throw without a key With Stripe connected, Affitor records each payment from the connected account, so the injected trackSale recorded a subscription's first payment twice (cs_ and in_ ids). onboard now reads stripe_connected from GET /v1/cli/status: connected → webhook unchanged, Connect recipe printed, an existing trackSale call is pointed out; unknown → ask, or with --yes/--json change nothing. The Stripe sale, Stripe renewal and Paddle snippets skip the call (Stripe ones log) when there is no customer key, instead of letting the SDK throw inside the brand's webhook. Tests run each snippet for real against an SDK-like stub. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ackSale advice when Stripe records sales Codex r1 on #41: stripe_connected is false while a bound account is pending_verification, yet Connect still credits its sales, and before CMS v3.16.91 it was true for any Server API program. onboard now reads stripe_account_bound (affiliate-cms#539) and treats its absence as unknown; it reads the binding before the wizard, which then prints the lead step only; a different AFFITOR_API_KEY already in the env file makes the answer unknown; comments mentioning trackSale are not reported as a double count; the Paddle snippet also skips a $0 total. Tests go through runOnboard; the snippet stub checks amount and invoiceId like the SDK. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sonpiaz
changed the title
…ksale-when-connected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent onboard from adding a second sale writer when Stripe Connect may record payments. A current binding=false/missing remains unknown; status is trusted only for one unambiguous runtime credential matching the checked key.
Following the r4 decision, uncertainty now asks interactively whether to keep the existing webhook unchanged (default Yes). Conflicting/duplicate keys, unknown root .env* layers, unreadable files and missing runtime credentials remain unknown; unattended runs preserve the snippet. Only explicit confirmation of the runtime program and absence of current/shared/delayed Connect sales, followed by a separate diff approval, can add manual sale tracking. Unknown advice never recommends deleting an existing call.
Use pinned dotenv17.3.1 for values and its quote-aware grammar for duplicate boundaries, handling colon assignments and multiline values. Ambiguous env files are preserved; genuinely missing keys can still be initialized. README documents conservative custom/template handling. Branch includes merged CLI#42 without modifying its installer.
Validation: build/lint, 284 tests (25 recipes, 239 CLI, 20 MCP; two Windows tests skipped locally). Nineteen new-decision/baseline regressions reproduced before fixing. Real @next/env confirms colon/multiline behavior. Four isolated mutants killed by 4/26/25/2 tests with submitted source hashes unchanged. CI Linux/Windows on exact head required before release. No publish or version bump; npm refreshed the MCP lock metadata to its existing package version0.2.2. CMS#539 and manager release gates still apply.