Repository navigation
Conversation
…gent-Field#1454) The tasks page located task.parallel in category spending, but /settings shows it under Tasks as 'tasks at once' (settings.go's CategoryTasks), so someone following the page searched the wrong section. Name the section and the row exactly as drawn, and add manual probes that reach the tasks page for the setting.
The generic probes only asserted that some section on the tasks page was returned, so restoring the former Spending wording left them green. Put the issue's exact query vocabulary in the section heading and add a focused test that finds that section, requires 'under Tasks as tasks at once', and rejects the former category. The test fails when the old wording is restored and passes with the correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The tasks manual located
task.parallelin category "spending", but/settingsshows it under Tasks astasks at once(settings.gohasCategory: CategoryTasks,Label: "tasks at once"). Someone following the page searched the wrong section (#1454).internal/manual/chat/tasks.md: the setting now reads "under Tasks astasks at once", naming the section and the row exactly as drawn.internal/manual/chat_test.go: two probes ("where is the tasks at once setting","what section is task.parallel under") assert the question reaches the tasks page.How it was checked
internal/manualdoes not fail on my Windows checkout only because of CRLF working-tree line endings (three unrelated character-count/blank-line tests), which the committed files (LF, confirmed viagit ls-files --eol) and CI never see. So I verified on a clean LF checkout in agolang:1.26Linux container:internal/manualsuite passes with this change applied (git reset --hard+git applythe patch, thengo test ./internal/manual/).TestTheChatManualAnswersTheQuestionsPeopleAsk(which runs the probe table) passes, so both new probes reach the tasks page.Checklist
docs/changes/unreleased/1886-tasks-at-once-manual-category.md..github/known-red.txt.Closes #1454.