Repository navigation
TPC residuals: JDL hook for extra scdcalib keys - #2517
Merged
shahor02 merged 1 commit intoOct 22, 2026
Merged
Conversation
The residual extraction's track selection (minPtNoOuterPoint, minTOFTRDPVContributors, ITS / TPC cluster cuts, ...) is hard-coded in setenv_extra.sh and cannot be changed from the JDL; in anchored MC the anchored configuration also overrides keys given on the command line. ALIEN_JDL_TPCRESIDUAL_EXTRACONFIG is appended after the defaults, so its keys win (later keys override earlier ones in configKeyValues). Example, keeping all tracks and clusters (needs O2 with scdcalib.keepClustersOnPropFail, >= 2026-10-07; unknown keys are fatal): scdcalib.keepClustersOnPropFail=true;scdcalib.clampTgSlp=true;scdcalib.minPtNoOuterPoint=0;scdcalib.minTOFTRDPVContributors=0 Unset: the configuration is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matthias-kleiner
requested review from
chiarazampolli,
davidrohr and
shahor02
as code owners
October 22, 2026 14:26
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The residual extraction's track selection (minPtNoOuterPoint, minTOFTRDPVContributors, ITS / TPC cluster cuts, ...) is hard-coded in setenv_extra.sh and cannot be changed from the JDL; in anchored MC the anchored configuration also overrides keys given on the command line. ALIEN_JDL_TPCRESIDUAL_EXTRACONFIG is appended after the defaults, so its keys win (later keys override earlier ones in configKeyValues). Example, keeping all tracks and clusters (needs O2 with scdcalib.keepClustersOnPropFail, >= 2026-10-07; unknown keys are fatal):
scdcalib.keepClustersOnPropFail=true;scdcalib.clampTgSlp=true;scdcalib.minPtNoOuterPoint=0;scdcalib.minTOFTRDPVContributors=0Unset: the configuration is unchanged.