[ALICE3] Fix casts

ALICE3/Core/FlatLutEntry.cxx

@@ -140,23 +140,23 @@ size_t FlatLutData::getEntryOffset(int nch_bin, int rad_bin, int eta_bin, int pt
 const lutEntry_t* FlatLutData::getEntryRef(int nch_bin, int rad_bin, int eta_bin, int pt_bin) const
 {
   size_t offset = getEntryOffset(nch_bin, rad_bin, eta_bin, pt_bin);
-  return reinterpret_cast<const lutEntry_t*>(mDataRef.data() + offset);
+  return reinterpret_cast<const lutEntry_t*>(mDataRef.data() + offset); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
 }
 
 lutEntry_t* FlatLutData::getEntry(int nch_bin, int rad_bin, int eta_bin, int pt_bin)
 {
   size_t offset = getEntryOffset(nch_bin, rad_bin, eta_bin, pt_bin);
-  return reinterpret_cast<lutEntry_t*>(mData.data() + offset);
+  return reinterpret_cast<lutEntry_t*>(mData.data() + offset); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
 }
 
 const lutHeader_t& FlatLutData::getHeaderRef() const
 {
-  return *static_cast<const lutHeader_t*>(static_cast<const void*>(mDataRef.data()));
+  return *reinterpret_cast<const lutHeader_t*>(mDataRef.data()); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
 }
 
 lutHeader_t& FlatLutData::getHeader()
 {
-  return *static_cast<lutHeader_t*>(static_cast<void*>(mData.data()));
+  return *reinterpret_cast<lutHeader_t*>(mData.data()); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
 }
 
 void FlatLutData::updateRef()
@@ -216,7 +216,7 @@ lutHeader_t FlatLutData::previewHeader(const uint8_t* buffer, size_t size)
   if (size < sizeof(lutHeader_t)) {
     throw framework::runtime_error_f("Buffer too small for LUT header: expected at least %zu, got %zu", sizeof(lutHeader_t), size);
   }
-  const auto* header = static_cast<const lutHeader_t*>(static_cast<const void*>(buffer));
+  const auto* header = reinterpret_cast<const lutHeader_t*>(buffer); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   if (!header->checkVersion()) {
     throw framework::runtime_error_f("LUT header version mismatch: expected %d, got %d", LUTCOVM_VERSION, header->version);
   }
@@ -246,7 +246,7 @@ FlatLutData FlatLutData::ViewFromBuffer(const uint8_t* buffer, size_t size)
 
 FlatLutData FlatLutData::ViewFromBuffer(std::span<std::byte> const& span)
 {
-  return ViewFromBuffer(reinterpret_cast<const uint8_t*>(span.data()), span.size_bytes());
+  return ViewFromBuffer(reinterpret_cast<const uint8_t*>(span.data()), span.size_bytes()); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
 }
 
 bool FlatLutData::isLoaded() const
@@ -257,7 +257,7 @@ bool FlatLutData::isLoaded() const
 lutHeader_t FlatLutData::previewHeader(std::ifstream& file, const char* filename)
 {
   lutHeader_t tempHeader;
-  file.read(reinterpret_cast<char*>(&tempHeader), sizeof(lutHeader_t));
+  file.read(reinterpret_cast<char*>(&tempHeader), sizeof(lutHeader_t)); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   if (file.gcount() != static_cast<std::streamsize>(sizeof(lutHeader_t))) {
     throw framework::runtime_error_f("Failed to read LUT header from %s", filename);
   }
@@ -282,7 +282,7 @@ FlatLutData FlatLutData::loadFromFile(std::ifstream& file, const char* filename)
   size_t numEntries = static_cast<size_t>(data.mNchBins) * data.mRadBins * data.mEtaBins * data.mPtBins;
   size_t entriesSize = numEntries * sizeof(lutEntry_t);
 
-  file.read(reinterpret_cast<char*>(data.data() + headerSize), entriesSize);
+  file.read(reinterpret_cast<char*>(data.data() + headerSize), entriesSize); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   if (file.gcount() != static_cast<std::streamsize>(entriesSize)) {
     throw framework::runtime_error_f("Failed to read LUT entries from %s: expected %zu bytes, got %zu", filename, entriesSize, static_cast<size_t>(file.gcount()));
   }

ALICE3/Core/FlatLutWriter.cxx

@@ -266,7 +266,7 @@ void FlatLutWriter::lutWrite(const char* filename, int pdg, float field, size_t
   setMap(lutHeader.ptmap, mPtBinning);
 
   // Write header to file
-  lutFile.write(reinterpret_cast<char*>(&lutHeader), sizeof(lutHeader_t));
+  lutFile.write(reinterpret_cast<char*>(&lutHeader), sizeof(lutHeader_t)); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   if (!lutFile.good()) {
     LOGF(error, "Failed to write LUT header to %s", filename);
     lutFile.close();
@@ -361,7 +361,7 @@ void FlatLutWriter::lutWrite(const char* filename, int pdg, float field, size_t
           diagonalise(lutEntry);
 
           // Write entry to file
-          lutFile.write(reinterpret_cast<char*>(&lutEntry), sizeof(lutEntry_t));
+          lutFile.write(reinterpret_cast<char*>(&lutEntry), sizeof(lutEntry_t)); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
           if (!lutFile.good()) {
             LOGF(error, "Failed to write LUT entry at index [%d,%d,%d,%d]", inch, irad, ieta, ipt);
             lutFile.close();

ALICE3/Core/FlatTrackSmearer.cxx

@@ -171,7 +171,7 @@ bool TrackSmearer::viewTable(int pdg, const uint8_t* buffer, size_t size, bool f
 
 bool TrackSmearer::viewTable(int pdg, std::span<std::byte> const& span, bool forceReload)
 {
-  return viewTable(pdg, reinterpret_cast<const uint8_t*>(span.data()), span.size_bytes(), forceReload);
+  return viewTable(pdg, reinterpret_cast<const uint8_t*>(span.data()), span.size_bytes(), forceReload); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
 }
 
 bool TrackSmearer::hasTable(int pdg) const

ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx

@@ -1036,7 +1036,7 @@ struct OnTheFlyMidPid {
       if (etStatus) {
         histos.fill(HIST("h1dEventTimedelta"), eventCollisionTimePS - tzero[0]);
       }
-      static_cast<TEfficiency*>(listEfficiency->At(0))->Fill(etStatus, dNdEta);
+      dynamic_cast<TEfficiency*>(listEfficiency->At(0))->Fill(etStatus, dNdEta);
     }
 
     // Then we do a second loop to compute the measured quantities with the measured event time

ALICE3/TableProducer/alice3-correlatorDDbar.cxx

@@ -115,7 +115,7 @@ struct alice3correlatorddbar {
 
   void init(InitContext&)
   {
-    auto vbins = (std::vector<double>)binsPt;
+    auto vbins = std::vector<double>(binsPt);
     registry.add("hMass", "D0,D0bar candidates;inv. mass (#pi K) (GeV/#it{c}^{2});entries", {HistType::kTH2F, {{massAxisBins, massAxisMin, massAxisMax}, {vbins, "#it{p}_{T} (GeV/#it{c})"}}});
     registry.add("hMassD0", "D0,D0bar candidates;inv. mass D0 only (#pi K) (GeV/#it{c}^{2});entries", {HistType::kTH2F, {{massAxisBins, massAxisMin, massAxisMax}, {vbins, "#it{p}_{T} (GeV/#it{c})"}}});
     registry.add("hMassD0bar", "D0,D0bar candidates;inv. mass D0bar only (#pi K) (GeV/#it{c}^{2});entries", {HistType::kTH2F, {{massAxisBins, massAxisMin, massAxisMax}, {vbins, "#it{p}_{T} (GeV/#it{c})"}}});

ALICE3/TableProducer/alice3DqTableMaker.cxx

@@ -301,7 +301,7 @@ struct Alice3DqTableMaker {
     fStatsList.setObject(new TList());
     fStatsList->SetOwner(true);
     std::vector<TString> eventLabels{"Collisions before filtering", "Before cuts", "After cuts"};
-    TH2I* histEvents = new TH2I("EventStats", "Event statistics", eventLabels.size(), -0.5, eventLabels.size() - 0.5, o2::aod::evsel::kNsel + 1, -0.5, (float)o2::aod::evsel::kNsel + 0.5);
+    TH2I* histEvents = new TH2I("EventStats", "Event statistics", eventLabels.size(), -0.5, eventLabels.size() - 0.5, o2::aod::evsel::kNsel + 1, -0.5, static_cast<float>(o2::aod::evsel::kNsel) + 0.5);
     int ibX = 1;
     for (auto label = eventLabels.begin(); label != eventLabels.end(); label++, ibX++) {
       histEvents->GetXaxis()->SetBinLabel(ibX, (*label).Data());
@@ -583,7 +583,7 @@ struct Alice3DqTableMaker {
             if (fDoDetailedQA) {
               j = 0;
               for (const auto& cut : fTrackCuts) {
-                if ((trackTempFilterMap & (uint8_t(1) << j)) != 0u) {
+                if ((trackTempFilterMap & (static_cast<uint8_t>(1) << j)) != 0u) {
                   fHistMan->FillHistClass(Form("TrackBarrel_%s_%s", cut->GetName(), sig->GetName()), dqefficiency_helpers::varValues()); // fill the reconstructed truth
                 }
                 j++;

ALICE3/TableProducer/alice3HfSelector3Prong.cxx

@@ -114,7 +114,7 @@ struct Alice3HfSelector3Prong {
     labels[1 + aod::SelectionStep::RecoPID] = "Skims & Topological & PID selections";
     labels[1 + aod::SelectionStep::RecoMl] = "ML selection";
     static const AxisSpec axisSelections = {kNBinsSelections, 0.5, kNBinsSelections + 0.5, ""};
-    registry.add("hSelections", "Selections;;#it{p}_{T} (GeV/#it{c})", {HistType::kTH2F, {axisSelections, {(std::vector<double>)binsPt, "#it{p}_{T} (GeV/#it{c})"}}});
+    registry.add("hSelections", "Selections;;#it{p}_{T} (GeV/#it{c})", {HistType::kTH2F, {axisSelections, {std::vector<double>(binsPt), "#it{p}_{T} (GeV/#it{c})"}}});
     for (int iBin = 0; iBin < kNBinsSelections; ++iBin) {
       registry.get<TH2>(HIST("hSelections"))->GetXaxis()->SetBinLabel(iBin + 1, labels[iBin].data());
     }

ALICE3/TableProducer/alice3TrackingTranslator.cxx

@@ -360,7 +360,7 @@ struct Alice3TrackingTranslator {
     if (filesList) {
       TIter next(filesList);
       TSystemFile* file;
-      while ((file = static_cast<TSystemFile*>(next()))) {
+      while ((file = dynamic_cast<TSystemFile*>(next()))) {
         TString fname = file->GetName();
         LOG(debug) << "Found file: " << fname.Data();
         if (!file->IsDirectory() && fname.EndsWith(".root")) {

ALICE3/Tasks/alice3-qa-multiplicity.cxx

@@ -41,7 +41,7 @@ struct ALICE3MultTask {
 
   void init(InitContext&)
   {
-    const AxisSpec axisMult{MaxMult.value > 10000.f ? 10000 : (int)MaxMult, 0, MaxMult, "Reconstructed tracks"};
+    const AxisSpec axisMult{MaxMult.value > 10000.f ? 10000 : static_cast<int>(MaxMult), 0, MaxMult, "Reconstructed tracks"};
     TString tit = Form("%.3f < #it{#eta} < %.3f", MinEta.value, MaxEta.value);
     histos.add("multiplicity/numberOfTracksNoCut", tit, kTH1D, {axisMult});
     histos.add("multiplicity/numberOfTracks", tit, kTH1D, {axisMult});

ALICE3/Tasks/alice3DqEfficiency.cxx

@@ -983,7 +983,7 @@ struct Alice3DqEfficiencyAnalysisSameEventPairing {
     fHistMan->SetUseDefaultVariableNames(true);
     fHistMan->SetDefaultVarNames(dqefficiency_helpers::varNames(), dqefficiency_helpers::varUnits());
 
-    VarManager::SetCollisionSystem((TString)fConfigOptions.syst, fConfigOptions.energy); // set collision system and center of mass energy
+    VarManager::SetCollisionSystem(TString(fConfigOptions.syst), fConfigOptions.energy); // set collision system and center of mass energy
 
     defineHistograms(fHistMan, histNames.Data(), cfgAddSEPHistogram.value.data());     // define all histograms
     dqhistograms::AddHistogramsFromJSON(fHistMan, cfgAddJSONHistograms.value.c_str()); // ad-hoc histograms via JSON

ALICE3/Tasks/alice3HfTask3Prong.cxx

@@ -119,7 +119,7 @@ struct Alice3HfTask3Prong {
       registry.add(("MC/gen/nonprompt/" + histoName + "GenNonPrompt").c_str(), ("MC particles (matched, non-prompt);" + xAxisTitle + ";" + yAxisTitle).c_str(), configSpec);
     };
 
-    auto vbins = (std::vector<double>)binsPt;
+    auto vbins = std::vector<double>(binsPt);
 
     /// Reconstructed Histograms
     addHistogramsRec("hMass", "inv. mass (p K #pi) (GeV/#it{c}^{2})", "", {HistType::kTH1F, {{600, 1.98, 2.58}}});