Repository navigation
[PWGHF] Fix BC association in charm-hadron flow task - #18400
Merged
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
zhangbiao-phy
marked this pull request as ready for review
October 22, 2026 05:33
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
xinyepeng
as code owners
October 22, 2026 05:33
Contributor
|
Hi @zhangbiao-phy, thanks for noticing and fixing! |
zhangbiao-phy
enabled auto-merge (squash)
October 22, 2026 06:57
alibuild
approved these changes
Oct 22, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @zhangbiao-phy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Marcellocosti , this PR fixes a issue introduced by #17652
The charm-hadron flow task fails when collisions and BCs have different row counts because
BCsWithTimestampsis included directly in the collision joins.Remove the BC table from all three collision joins and provide it as a separate input to the candidate processing functions. Access the associated BC through
collision.bc_as<aod::BCsWithTimestamps>()to preserve the run-dependent resolution updates and candidate-by-candidate SP correction.