Skip to content

[PWGUD] New functionality for Pb-Pb analyses - #18509

Merged
ekryshen merged 5 commits into
AliceO2Group:masterfrom
ekryshen:master
Oct 29, 2026
Merged

ekryshen merged 5 commits into
AliceO2Group:masterfrom
ekryshen:master

Conversation

@ekryshen

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgud label Oct 29, 2026
@github-actions github-actions Bot changed the title New functionality for Pb-Pb analyses [PWGUD] New functionality for Pb-Pb analyses Oct 29, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 7 disabled

@ekryshen
ekryshen enabled auto-merge (squash) October 29, 2026 16:06
alibuild
alibuild previously approved these changes Oct 29, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ekryshen.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 400950e at 2026-10-29 18:24:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 400950e at 2026-10-29 18:25:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 400950e at 2026-10-29 18:26:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5d9846b at 2026-10-29 23:14:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 11 warnings.'
Found 5 errors and 11 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/3382d03b71b4fb5bf8ccc99dfe164d10479fcec9/O2Physics-code-check/errors.txt
PWGUD/TableProducer/upcCandProducerBarrel.cxx:43:1: error: included header TH1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:124:41: error: no header providing "TH3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:547:40: error: no header providing "TESTBIT" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:590:37: error: no header providing "std::accumulate" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:598:37: error: no header providing "std::accumulate" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/3382d03b71b4fb5bf8ccc99dfe164d10479fcec9/O2Physics-code-check/warnings.txt
PWGUD/TableProducer/upcCandProducerBarrel.cxx:294:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:296:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:298:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:300:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:598:48: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:598:63: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:599:48: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:599:63: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:697:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:705:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/TableProducer/upcCandProducerBarrel.cxx:712:30: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@ekryshen
ekryshen merged commit fc4710c into AliceO2Group:master Oct 29, 2026
12 of 13 checks passed
@vkucera

vkucera commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

@ekryshen Please fix the errors.

@ekryshen

Copy link
Copy Markdown
Collaborator Author

@vkucera Fixed here:
#18517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants