Repository navigation
SortedList in C#: move to .NET 10, fix the RemoveAt example, add a memory comparison - #2309
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
… comparison Retarget both projects to net10.0 and update the test packages (MSTest 4.5.1, Test SDK 18.11.0, coverlet 10.1.0). Fix the RemoveAt index so the example removes key 2, correct the non-generic exception comment, add a read-by-key-and-index method with tests, and add a program that compares the memory a SortedList, SortedDictionary and Dictionary keep for 100,000 int pairs, including a SortedList after TrimExcess().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the SortedListInCSharp sample from net6.0 to net10.0 with MSTest 4.5.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0, swaps the expected and actual arguments the MSTest analyzer flags, fixes the RemoveAt index so the remove example takes out key 2 as its comment says, corrects the non-generic exception comment to InvalidOperationException, adds a method and a test that read values by key and by index, adds a test for the non-generic key type failure, and adds a small program that measures the memory a SortedList, a SortedDictionary and a Dictionary keep for 100,000 int pairs, plus a SortedList after TrimExcess().