Repository navigation
London | 26-ITP-Sep | Mahir Shah | Sprint 2 | 3 Implement and rewrite tests - #1686
Open
MahirShah300 wants to merge 16 commits into
Open
MahirShah300 wants to merge 16 commits into
MahirShah300 wants to merge 16 commits into
Conversation
MahirShah300
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MahirShah300
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
MahirShah300
changed the title
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MahirShah300
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Oct 17, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Good implementation overall, couple of minor issues needs attention. Thanks
|
|
||
| if (!validSuits.includes(suit)) { | ||
| throw new Error( | ||
| `Invalid input. Expected a number followed by a suit, but got "${card}"` |
There was a problem hiding this comment.
The error is a bit misleading, its not always a number followed by a suit, please review the conditions again from the top of the file.
Author
There was a problem hiding this comment.
I have changed the error message
| test(`Should get Invalid when given "2♦ " card with trailing whitespace`, () => { | ||
| expect(() => getCardValue("2♦ ")).toThrow(/Invalid/); | ||
| }); | ||
| test(`Should get Invalid when given "2♦ " card with trailing whitespace`, () => { |
Author
There was a problem hiding this comment.
I have removed the duplicate test
hey-hammad
added
Reviewed
MahirShah300
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1059
Changelist
Implemented the functions and wrote tests using node and jest.