Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Enhances the Data Browser Inspect Waveforms view by replacing the existing waveform display with a ChartFX-based implementation that supports multiple PVs, waveform history, and improved visualization controls.
Changes
phoebus.waveform.max_pvssystem property.Implementation
Introduces
WaveformHistoryChart, using ChartFX'sHistoryDataSetRendererto manage waveform history. The existingWaveformViewis updated to support multiple selected PVs and display their histories using a common sample-time reference.The implementation preserves the existing Data Browser model and sample retrieval mechanisms.
Testing
Scope
Changes are limited to the Data Browser. No Display Builder widget changes are included.