Skip to content

fix(skills): hot-remove deleted skills by id, not directory name (#417) #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ALDL (victor-commit) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(skills): hot-remove deleted skills by id, not directory name (#417) #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/cortex-skills/src/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,15 +369,21 @@ impl SkillManager {
}
}
WatchEvent::Deleted(path) => {
// Remove skill if its SKILL.toml was deleted
// Remove the skill whose source directory was deleted.
// Skills are keyed by their id (derived from the
// SKILL.toml `name`), which need not match the directory
// name, so match on `source_path` rather than the dir name.
if let Some(skill_dir) = path.parent() {
let skill_id = skill_dir
.file_name()
.and_then(|n| n.to_str())
.unwrap_or("")
.to_lowercase();
if skills.remove(&skill_id).is_some() {
info!("Hot-removed skill: {}", skill_id);
let mut removed: Vec<String> = Vec::new();
skills.retain(|id, skill| {
let keep = skill.source_path.as_path() != skill_dir;
if !keep {
removed.push(id.clone());
}
keep
});
for id in removed {
info!("Hot-removed skill: {}", id);
}
}
}
Expand Down