Repository navigation
test(ledger): guard the accepted filter of the bootstrap pending count - #30
Merged
Merged
Conversation
production_bootstrap counts pending shadow reservations against the issuance cap with `accepted IS NULL`. An accepted reservation is already in balances().issued, so dropping the filter double counts it and refuses a bootstrap that exactly fits the cap. Lens found no test failed when the filter was removed. Add one with an accepted reservation at an exact fit; it fails with the filter removed. Tests only, nothing under src/. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies a ledger test that guards the accepted-reservation filter in the bootstrap pending count. It matches the main change. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Lens review of #27 found a surviving mutant: removing
accepted IS NULLfrom the pending-reservation count inproduction_bootstrapleft all tests green.What
One test,
test_bootstrap_ignores_accepted_shadow_reservation: an accepted reservation row plus a cap that exactly fits the bootstrap. The bootstrap must be accepted. Tests only, nothing undersrc/.Evidence
pytest tests/ledger/test_production_bootstrap_v2.py: 16 passed.escrow_v2.py): 1 failed, the new test; 15 passed.ruff checkandruff format: clean.Risk / rollback
Tests only. The missed case fails closed (refuses a bootstrap, never over-issues). Revert the merge.
Summary by CodeRabbit