Repository navigation
SBS log gathering: per feature consent, one queued batch, device ID change and stopped gather tail - #319
Merged
Conversation
… time - A gathered line needs the consent of the feature its bracket names. A line of no feature needs the events and user profiles consents the app enabled, and removing a consent drops the held lines of that feature. - One sdk_logs request waits in the queue at a time, checked against the stored request, and a sent batch resumes only a delivery it held back. - A device ID change without merge queues the held lines and the tail of a stopped gather under the old ID and stops the gather. An answer requested before that change no longer arms it, while a change with merge keeps it. - A gather the server stops uploads its last lines once, under its ID. - The networking decides between a drain and a recheck under one lock, and a failing drain still rechecks. - SessionImpl logs event, location and view data after the feature check. - The test RSA key is 2048 bits (CodeQL).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open log gathering items from the #275 review, following the reference SDK's log module. Base:
sdk-behavior-settings.What changes
networking: falseAlso in here:
SessionImpllogs event, location and view data after the feature check, not before.Tests
LogTests(one batch at a time, a dropped batch, a removed consent, device ID change, stopped gather tail),SdkLogGatheringTests(per feature consent end to end, a feature not enabled, a merge after a held answer),DefaultNetworkingRecheckTests(a failing drain still rechecks).Review notes
Log.LogBatchQueuenow returns the storage ID of the queued request and answers whether it is still stored;ModuleRequests.pushSdkLogsreturns that ID.Countly.instance()lock, and waits for each batch's store (bounded by the existing 10 s cap).🤖 Generated with Claude Code