Repository navigation
grep improvement update using ripgrep - #486
Merged
Merged
Conversation
zfoong
added
priority: high
Improvement
ahmad-ajmal
reviewed
Oct 15, 2026
ahmad-ajmal
left a comment
ahmad-ajmal
left a comment
Collaborator
There was a problem hiding this comment.
One memory usage issue in the search result parsing:
ahmad-ajmal
approved these changes
Oct 15, 2026
ahmad-ajmal
left a comment
ahmad-ajmal
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed dadd733. The memory issue is fixed, and I found no further actionable issues. The 17 search tests passed in the isolated harness, 70 comparison cases preserved the previous search output, and all six CI checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Grep takes too much time to run, improved with ripgrep. Reducing search time from mintues to seconds.
The ripgrip binarry is also added by default, a vendor_ripgrep script is there for future update of the binary file.