Repository navigation
Conversation
fstagni
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works together with DIRACGrid/WebAppDIRAC#813
Summary
Removes the
getTokensByUserIDRPC from the TokenManager service:TokenManagerHandler (src/DIRAC/FrameworkSystem/Service/TokenManagerHandler.py) export_deleteToken - export_getTokensByUserID # types_getTokensByUserID = [str]TokenDB.getTokensByUserIDis kept: it is still used internally byexport_getUserTokensInfo,export_getUsersTokensInfoandexport_getToken.Evidence
grep getTokensByUserIDafter the change only shows the internalTokenDBusages (TokenManagerHandler lines 80/105, TokenDB).TokenManager.getTokensByUserIDin the repo.Merge Danger
Door: two-way
Re-adding the export is trivial if any external client turns out to rely on it.
Blast Radius: TokenManager service clients only - any external code calling
TokenManager.getTokensByUserIDwould break.