Repository navigation
Conversation
Member
|
Do you want a review on this? |
Member
Author
You can. The fix is pretty small. |
`fel` checks that the failure event, counter and invariant are only modified inside the oracles it emits per-oracle goals for, using the statement-level write-set with those oracles excepted. `i_write_r` returned early on a call to an excepted oracle and dropped the call's lvalue, so `bad <@ o();` in the main body was not seen as a write to `bad` and an unsound bound could be derived. The lvalue is written by the caller regardless of the callee, so add it to the write-set before the `except` test. This matches the function-level write-set, which already counts call lvalues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
felchecks that the failure event, counter and invariant are onlymodified inside the oracles it emits per-oracle goals for, using the
statement-level write-set with those oracles excepted.
i_write_rreturned early on a call to an excepted oracle and dropped the call's
lvalue, so
bad <@ o();in the main body was not seen as a write tobadand an unsound bound could be derived.The lvalue is written by the caller regardless of the callee, so add
it to the write-set before the
excepttest. This matches thefunction-level write-set, which already counts call lvalues.
Closes #1126