Repository navigation
fix(arc): give the node-cache init container the capabilities its mkdir needs - #93
Merged
Merged
Conversation
… a non-root pod context The runner user writes to the node-cache directory the init container prepared, in a pod whose securityContext is non-root, as a cluster may impose.
…fails before its step
The command gives the node directory to the runner user and then creates a subdirectory in it. Root with only CHOWN is an ordinary user of a directory it no longer owns, so mkdir was denied and the pod stopped in Init:Error.
Mearman
marked this pull request as ready for review
October 15, 2026 06:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… its capabilities mkdir and chown need only CHOWN and DAC_OVERRIDE. The README and the docstring now give the reason: the node directory is already the runner user's when an earlier pod or the pruner left it.
…single init container The step ran without errexit in the seeded pod, so a wrong owner or an unwritable directory still ended in the pod's success marker. Both steps now stop at the first failed assertion and print the owners and modes they check.
|
🎉 This PR is included in version 1.31.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node-cache init container hands the node directory to the runner user and then creates a subdirectory in it. Root with only CHOWN is an ordinary user of a directory it does not own, so mkdir was denied and the pod stopped in Init:Error, whether the directory was fresh or already the runner user's from an earlier pod or the pruner. The init container now adds DAC_OVERRIDE to CHOWN. The in-kind capabilities test runs a node-cache capability in real pods under a non-root pod securityContext, once on a directory already owned by the runner user with no subdirectory and once on a fresh one. Refs #90.