Repository navigation
Add missing @Test annotation to OptionalTest.testIssue372Deser() - #393
Merged
cowtowncoder merged 1 commit intoOct 22, 2026
Merged
Conversation
The regression test for FasterXML#372 was written on `2.18`, where this class still extended a JUnit 3 `TestCase` base and methods were collected by name. `2.19` had already migrated to JUnit 5 in FasterXML#344, so the merge from `2.18` carried the method over without an annotation and nothing has run it since. `ModuleTestBase` does not extend `TestCase` and nothing in the file calls the method, so it has been dead since 2.18.5 shipped the fix in October 2025. `mvn test -Dtest=OptionalTest` in `datatypes` goes from 13 tests to 14. The method passes as written, so this adds coverage without changing behaviour.
cowtowncoder
approved these changes
Oct 22, 2026
Member
|
Thank you, @dylanpulver ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression test for #372 is not run.
It was written on
2.18, whereOptionalTestwas still collected by method name through a JUnit 3 base class.2.19had already migrated to JUnit 5 in #344, so the merge from2.18carried the method across without an annotation.ModuleTestBasedoes not extendTestCaseand nothing in the file calls the method, so it has not run since 2.18.5 shipped the fix in October 2025.mvn test -Dtest=OptionalTestindatatypesgoes from 13 tests to 14. The method passes as written, so this adds coverage without changing behaviour. Removing the annotation again drops it back to 13.Test-only, so CLA-exempt per CONTRIBUTING#paperwork.