Repository navigation
Conversation
The typing indicator had a fixed teal that was barely visible in dark mode; it now takes the theme's secondary text color. Several fallbacks named Aura tokens that do not exist or do not fit: the popover radius took the unitless --aura-base-radius, which left it square, the resize arrows fell back to a fixed 20% black and the unread badge to a fixed orange with white text. They now use --vaadin-radius-l, --vaadin-border-color and Aura's yellow accent class, and the FAB shadow uses Aura's shadow tokens. The content of the mobile dialog is content-box in Aura and the base styles, so its padding pushed the close button and the message input past the dialog. The who-is-typing line had the same problem in every theme and overflowed the footer. Both are now border-box. In the demo, the "small" class of the lazy loading demo, easy to mistake for FabVariant.SMALL, is now "compact" and has an Aura fallback, and the chatbot avatar gets a white background in dark mode, where its dark icon was barely visible. Close #75
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe chat assistant updates theme-token fallbacks and sizing rules. The demo switches from the ChangesChat assistant styling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (3 skipped: 3… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes the main changes: adapting styles for Aura, base styles, and dark mode. It is concise and related to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (3 skipped: 3 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
paodb
approved these changes
Oct 15, 2026
github-project-automation
Bot
moved this from To Do
to Pending release
in Flowing Code Addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the two spots reported in #75, plus other places where the styles were not adapted to Aura, the Vaadin 25 base styles or dark mode. Lumo tokens stay first in every fallback chain, so Lumo only changes where noted below.
Reported in #75
#1c4c5b, barely visible in dark mode. They now take the theme's secondary text color, with the old color as the last fallback. In light Lumo this turns them from teal to gray, the same color as the "is typing" text.smallclass: its font size had no Aura fallback, and now has one. The class is also renamed tocompact, sincesmallwas easy to mistake forFabVariant.SMALL, which resizes the FAB.Also fixed
--aura-base-radius, a unitless multiplier (3). That made the declaration invalid and left the chat window with square corners in Aura. It now uses--vaadin-radius-l.--aura-accent-yellow, which is a class, not a custom property, so Aura showed a fixed orange with white text. The badge now carries theaura-accent-yellowclass and uses--aura-accent-color, so Aura renders it yellow with dark text, as Lumo does.--aura-border-colordoes not exist, so they fell back to a fixed 20% black, nearly invisible in dark mode. They now use--vaadin-border-color.--aura-shadow-s/--aura-shadow-m, which adapt to dark mode, before the literal shadows.--vaadin-gap-sas its Aura and base fallback.Demo
chatbot.pngis a dark icon on a transparent background, barely visible in dark mode. It now gets a white background in dark mode and keeps the theme's background in light mode. The rule replaces two custom properties left over from the oldchat-botelement, which nothing read anymore.Not covered
These predate this PR:
<body>, so the demo'sanimated-fab.compact vaadin-messageselector is not expected to match there. Not tested on Vaadin 24.<body>, so it does not pick up a theme applied to only part of the page. Switching the theme of the whole page works.Testing
Checked in the demo on Vaadin 25 (
-Pv25) with Lumo, Aura and the base styles. The widths of the dialog and the footer and the avatar background were measured with Playwright. Not tested on Vaadin 24, and unit tests were not run locally; CI runs both profiles.Summary by CodeRabbit