Repository navigation
Conversation
dkachuma
added
the
ci: run device builds
dkachuma
marked this pull request as ready for review
October 18, 2026 13:24
dkachuma
requested review from
OmarDuran,
bd713,
cssherman,
herve-gross,
jafranc,
jhuang2601,
joshua-white,
rrsettgast and
tjb-ltk
as code owners
October 18, 2026 13:24
herve-gross
approved these changes
Oct 18, 2026
jhuang2601
requested changes
Oct 30, 2026
| // Transform to reference temperature space | ||
| minTemperature -= m_referenceTemperature; | ||
| maxTemperature -= m_referenceTemperature; | ||
| // Follow the CO2 brine example and validate in the range [10,200] deg C |
Contributor
There was a problem hiding this comment.
why this hard coded value was used? The JT benchmark's fluid table goes down to −10 °C.
| parser.add_argument( | ||
| "-r", "--reference", | ||
| action="store_true", | ||
| help="Flag to load and show reference data from 'odenburg.json'. (Default: False)" |
Contributor
There was a problem hiding this comment.
Suggested change
| help="Flag to load and show reference data from 'odenburg.json'. (Default: False)" | |
| help="Flag to load and show reference data from 'oldenburg.json'. (Default: False)" |
dkachuma
added a commit
that referenced
this pull request
Nov 2, 2026
Updated the link for PR #4080 to the latest baseline tar.gz file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new functionality for thermal compositional models: Introduces new non-isothermal compositional multiphase fluid models, specifically
CompositionalTwoPhaseThermalFluidLohrenzBrayClark,CompositionalTwoPhaseThermalFluidPhillipsBrine, andCompositionalTwoPhaseKValueThermalFluidPhillipsBrine. These models couple real-gas equations of state (evaluating ideal-gas heat capacity and departure enthalpy) with the energy balance to support processes involving drastic temperature and composition changes.Adds a benchmark example: Cooling during CO2 Injection into a Gas Reservoir. Incorporates a Joule-Thomson cooling validation study simulating constant-rate CO2 injection into a depleted CH4 gas reservoir. The setup reproduces the 5 mD case from Oldenburg (2007) .
Adds PVT driver tests to cover the fluid models: Expands the
constitutiveDriversuite with a newtestPVT_ThermalCompositionaltest deck. This tests both thermal flash and thermal K-value formulations using dynamic pressure and temperature functions to validate phase splits, compressibility, and phase composition outputs.Failing integrated test due to failure to restart when we have thermal wells. See #4036