Repository navigation
chore(secretmanager): include API action in tracing snippet filenames and remove step numbering - #14672
Conversation
… and remove step numbering
product-auto-label
Bot
added
api: secretmanager
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames several Secret Manager tracing snippet files and their tests to use more descriptive names, adds the opentelemetry-instrumentation-grpc dependency, and refactors mock transport initializations in the tests. A review comment identifies an issue in secretmanager_get_secret_version_trace_client_options_test.py where the fallback ClientOptions is not assigned back to kwargs, preventing the parent constructor from receiving the tracer provider.
|
Here is the summary of changes. You are about to add 4 region tags.
You are about to delete 4 region tags.
This comment is generated by snippet-bot.
|
Follow-up to #14647 to address post-merge review feedback:
secretmanager_trace*.pytoget_secret_version_trace*.pyto match the existingget_secret_version.pyconvention insecretmanager/snippets/while preserving all existing region tags (secretmanager_enable_tracing,secretmanager_enable_tracing_async,secretmanager_trace_client_options,secretmanager_trace_cloud_trace).1.,2., etc.) from inline comments across the snippets and test files.