Repository navigation
fix: read OLLAMA_HOST when its scheme is not lowercase - #12
Merged
Merged
Conversation
HTTP://gpu.lan:11434 is the same server as http://gpu.lan:11434. The scheme was matched case-sensitively, so the value was rejected and graphicle config set model ollama saved http://127.0.0.1:11434 instead. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OLLAMA_HOST=HTTP://…was rejected because the scheme match was case-sensitive.graphicle config set model ollamathen savedhttp://127.0.0.1:11434instead of that host. Schemes are matched case-insensitively, the same way RFC 3986 defines them.Test plan
cargo test --lib -- ollama_host_is_read_as_ollama_reads_itfails:HTTP://gpu.lan:11434returnsNone.HTTP://,Https://, and an IPv6 host.OLLAMA_HOST=HTTP://gpu.lan:11434 graphicle config set model ollamawriteshttp://gpu.lan:11434.Made with Cursor