Repository navigation
fix: accept the Host header browsers send on port 80 - #13
Merged
VikramLex merged 1 commit intoOct 26, 2026
Merged
Conversation
graphicle serve --port 80 allowed only 127.0.0.1:80 and localhost:80. HTTP clients omit the default port, so a browser or curl sent 127.0.0.1 or localhost and every request was refused as an unexpected host. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graphicle serve --port 80allowed only127.0.0.1:80andlocalhost:80.Host: 127.0.0.1,Host: localhost, andHost: [::1]were refused. Port 80 now accepts those bare hosts. Other ports stay port-qualified.Test plan
127.0.0.1:80is only127.0.0.1:80andlocalhost:80, so the bare-host assertions fail.cargo test --lib -- the_default_http_port_allows_the_host_header_without_a_portpasses for IPv4, IPv6, and the usual port 8854.graphicle serve --port 80acceptscurl http://127.0.0.1/andcurl http://localhost/.Made with Cursor