Repository navigation
Fix isolated deinit crashes in Markdown rendering helpers - #16
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid the isolated-deinitializer back-deployment path when synchronous Markdown rendering releases
ListProcessorand its ownedInlineAttributeCache.Problem
Production SIGABRT stacks during assistant-message and plan-preview rendering show nested destruction of these classes through
swift_task_deinitOnExecutorMainActorBackDeploy, ending inswift::TaskLocal::StopLookupScopeand an invalid free. Both classes inherit the target's default MainActor isolation and have implicit destructors.Solution
Add explicit empty
nonisolated deinitimplementations to both classes. Their rendering APIs retain MainActor isolation; the destructors contain no actor-dependent cleanup. Add synchronous lifetime tests for direct cache release and processor/owned-cache release inside a task-local scope.Validation