Repository navigation
Complete client CWV loading, reservation and GPT initial delivery - #1460
Draft
ChristianPavilonis wants to merge 5 commits into
Draft
ChristianPavilonis wants to merge 5 commits into
ChristianPavilonis wants to merge 5 commits into
Conversation
| targetingKeys[record.elementId] = record.targetingKeys; | ||
| } | ||
| } | ||
| function registeredCandidateAllowed(ts, slotId, bid) { |
4 tasks
Defer supported GPT runtime with early APIs and CSP-safe synchronous fallback. Add explicit responsive reservation, measured browser contracts, framework coverage and validation records for #854.
12 of 15 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Addresses #854 in this existing draft PR: publisher-owned slot registration, dependency-safe JS deferral, explicit responsive slot reservation, and repeatable browser measurements.
21f43aa0138498023455789f152f5a864bbefe24, preserving its APS failure relay, iframe/timeout ownership, asynchronous HTML EOF and origin-header rewriting. Thread actual path/CSP through the new EOF driver.Controlled measurements
Fresh Rust HTML, exact production JS, Chromium 145, five alternating samples per group and a controlled 750 ms runtime hold. Baseline is the unchanged
c36c82dfarchive. Current output includes newer main, Node/Rust and build dependencies, so this is not an isolated PR-effect estimate or field-CWV claim.No production ad-startup improvement is inferred from local request/visibility timings. Transfer cost increases: estimated HTML+runtime gzip is 42,104 → 50,583 bytes, +8,479. The existing 56,429-byte raw bootstrap remains, and the compiled early entry adds 56,602 bytes. This is not a size-reduction result.
Local verification
Code merge:
7b83a8ce87e773e2234a6dde7380a123f36e7d1f. Final fixture/evidence commit:6a5cfd54d.dad40087f6123d73b8465d774bd3212e7b25b4d6c8ce3051579f263e0d117f23.Limits and retained failures
Hosted CI is separate from local results. The PR is mergeable and the full workflows now run. On final head
6a5cfd54d, CodeQL and all language analyses passed, including Rust; the four earlier fixture findings are cleared. Remaining test/integration jobs are still running, so full hosted success is not claimed yet. Standalone package-wide TypeScript still fails with existing main/branch diagnostics; there are no new merge signatures or extracted-helper errors. Whole-repository actionlint also reports unchanged upstream workflow issues; the changed integration workflow passes.Initial Chromium crash/stall attempts, the temporary-file quota failure and original URL-lint failures remain documented separately. Serial browser retries passed unchanged inputs without weaker assertions or browser flags. Browser crash cause remains unproven.
No real GPT/GAM staging, customer-page testing, live customer auctions, deployment, production activation or field-CWV validation has run. Those require separate approval. The fixtures use fictional data and simulated GPT transport.
Records