Repository navigation
Test: Remove Dead Toplist GUI and Keys - #12333
Open
matheuszych wants to merge 1 commit into
Open
matheuszych wants to merge 1 commit into
matheuszych wants to merge 1 commit into
Conversation
matheuszych
force-pushed
the
remove_dead_toplist_code
branch
from
October 30, 2026 09:52
314afe6 to
20a50e5
Compare
The test highscore toplist screen is not available in ILIAS 12, but `ilTestToplistGUI`, a ctrl call in `ilTestResultsGUI`, and assessment language variables for that UI were still present. Removed the unused GUI class, the `@ilCtrl_Calls` annotation, and obsolete strings (`toplist_by_score`, `toplist_by_time`, `toplist_col_score`, `tst_show_toplist`). Left `toplist_col_*` entries that CmiXapi and LTI still load from the assessment module.
matheuszych
force-pushed
the
remove_dead_toplist_code
branch
from
October 30, 2026 09:58
20a50e5 to
47b4c0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test highscore toplist screen is not available in ILIAS 12, but
ilTestToplistGUI, a ctrl call inilTestResultsGUI, and assessment language variables for that UI were still present. Removed the unused GUI class, the@ilCtrl_Callsannotation, and obsolete strings (toplist_by_score,toplist_by_time,toplist_col_score,tst_show_toplist). Lefttoplist_col_*entries that CmiXapi and LTI still load from the assessment module./cc @thojou