Repository navigation
feat(agent-vault): install access bundle skills for agents - #462
Open
saifsmailbox98 wants to merge 8 commits into
Open
saifsmailbox98 wants to merge 8 commits into
saifsmailbox98 wants to merge 8 commits into
Conversation
|
💬 Discussion in Slack: #pr-review-cli-462-feat-agent-vault-install-access-bundle-skills-for-agents Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
6 of 11 tasks
Contributor
 [Medium impact] The PR changes the Agent Vault run and skill-publishing workflows. The PR still needs a way for proxy-only hosts to download their attached skills before merging. Findings
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![veria-ai[bot]](https://avatars.githubusercontent.com/in/1723776?s=60&v=4){kind=small}
Contributor
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
# Conflicts: # packages/agentvault/resolve.go # packages/api/agent_vault_test.go # packages/cmd/agent_vault_run_test.go
Member
Author
|
@greptile review |
Links into Claude Code and Hermes only replace a link or an earlier copy of the skill, Claude Code is linked when it is the agent, and --no-skills skips the step. A 401 right after minting is retried, the server's reason is shown, older servers are recognised, and the skills step handles the same signals as the agent step. Revoke at a normal exit gets its retries back.
A SKILL.md header that isn't valid YAML names the line, and an unquoted value with ': ' is told to use double quotes. A domain without the skills route now warns, the server's message no longer gets a second period, and a second signal during the interrupt revoke cuts it short with its warning. --skills-dir expands ~, and agent folders are reported as absolute paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Adds skills to
infisical agent-vault run. Before the agent starts, the CLI downloads the session's skills once from Infisical (GET /v1/agent-vault/session/skills, authenticated with the session token) and installs them on the host.~/.agents/skills/<name>, which Codex, OpenCode and OpenClaw read~/.claude(or$CLAUDE_CONFIG_DIR) or~/.hermes(or$HERMES_HOME) exists, or the agent command isclaude, the skill is linked into that agent'sskillsfolder. Falls back to a copy where links are not allowed (Windows without developer mode), and skips the link when that folder already resolves to~/.agents/skillsskillsfolder only a link or an earlier copy of the same skill is replaced. Any other folder with that name is left alone with a warning--skills-dir <folder>installs into another folder, with no links.--no-skillsskips the step, for hosts that can't reach Infisicalsha256before writing, and file paths, modes and symlinks are validated on writeInstalled N skills in <dir> (linked in <claude skills dir> and <hermes skills dir>).Also adds
infisical agent-vault skills push <folder>, which creates a skill or publishes a new version of it from a local folder (keeps executable bits, skips hidden files).Companion PR: Infisical/infisical#8981
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets