Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the daemon starts in a mount namespace containing an earlier dex2oat wrapper bind mount, Dex2OatServer can cache the wrapper itself as the stock compiler. The wrapper then execs that FD through the linker, re-enters main in the same process, and repeatedly acquires descriptors and copies the hook library.
This change:
Validation:
Device validation (2026-10-14):
Interpretation and limits:
Motivation: a Xiaomi 14 / Android 16 / KernelSU temporary-root setup running Vector 2.2 (88f8e1f) exhibited repeated wrapper entry in one PID, with stock descriptors increasing beyond 10,000 and the next DEX2OAT_CMD referring to the previous stock FD. This is consistent with recursive exec; the exact event that left the stale mount was not captured.
Related to the daemon lifecycle concerns in #878, but this does not fix duplicate daemon ownership or claim to resolve that entire issue. The existing unmount/fallback operation is best-effort; automatic stock-FD recovery and complete soft-reboot lifecycle handling remain outside this change.