Repository navigation
Fix SQL semantics and add VARBINARY - #390
Merged
Merged
Conversation
Share MarkApply preparation between WHERE and SELECT consumers, bind marker output positions through an expression iterator, and remove placeholder predicates. Reject UPDATE targets that are not base tables and cover view writes.
Cover scalar identity and spill codecs, persistent statistics, checkpoint recovery, parameter ranges, ORM writes and ALTER failure atomicity. Consolidate scalar-function SLT files and exclude test-only regions from coverage. Fix ORM HAVING binding against the actual aggregate outputs.
- Deduplicate non-null AVG inputs only when DISTINCT is requested and preserve DISTINCT in aggregate display. - Reject DISTINCT wildcard arguments before wildcard lowering while keeping COUNT(*) and COUNT(DISTINCT '*') valid. - Cover simple, grouped, empty, and cached DISTINCT aggregate results.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 93.68% 93.53% -0.16%
==========================================
Files 260 260
Lines 48783 34412 -14371
==========================================
- Hits 45704 32188 -13516
+ Misses 3079 2224 -855
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Several SQL semantics diverged from SQLite/PostgreSQL behavior, and binary values and uncorrelated quantified subqueries in SELECT were unsupported.
Issue link:
What is changed and how it works?
IN/ANY/ALL) in the SELECT list by sharing MarkApply preparation with WHERE.VARBINARYvalues with casts, comparison, and spill/serialization support.DataBaseBuilder::parser_recursion_limit.REPLACEto overwrite semantics, bind index DDL options explicitly, honorAVG(DISTINCT), and rejectDISTINCT *arguments.Code changes
Check List
Tests
Side effects
Note for reviewer
make testpasses (533 tests) and all SLT files pass.REPLACE, andAVG(DISTINCT)now return different results than before.