Repository navigation
Use the Search API in the issue search example - #1166
Merged
Merged
Conversation
Closes KnpLabs#1118. Replace the removed Issue::find call and extract issues from the search response items, with an is:issue filter and first-page semantics.
acrobat
approved these changes
Oct 23, 2026
Collaborator
|
Thanks @jihtsan! And congrats on your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue-search example calls the removed
Issue::find()method and fails when copied into current clients. Use the supported Search API, filter closed issues in the specified repository, and extract the current page from the responseitemsfield.Closes #1118.
Validation: extracted and syntax-checked the PHP snippet, then executed it against the repository’s actual
Searchclass with a checked local HTTP dispatch stub; API selection,/search/issuesquery and item extraction passed. The equivalent read-only GitHub API query returned the documented response envelope and closed issues, without pull requests.git diff --checkand independent Standards/Spec reviews passed. The complete library test suite and other PHP versions were not run for this documentation-only change.