Repository navigation
Fix imported vanilla ore rules - #323
Merged
SkyBlade1978 merged 1 commit intoOct 23, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
SkyBlade1978
merged commit Oct 23, 2026
c45ea2a
into
MinecraftModDevelopmentMods:master-26.1.2
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported vanilla rules now stay inactive while Manage Vanilla Ores is off. With it on, an active import replaces the matching default instead of adding a second placement pass. Saved placement choices and existing chunks are preserved.
This adds regression tests for imported rules, deepslate variants, dimension limits and saved Ore Sources choices. Validation covers 216 automated tests, fresh/reloaded worlds, no-retrogen checks, packaged clients and servers, Eclipse isolation and matched performance runs.