Repository navigation
cq-viewer 1.2.0: keep picking after the annotation panel opens - #22
Merged
Merged
Conversation
Before: 确认 turned pick mode off, and points picked after re-entering it waited for another 确认, so you could not pick a point, write its note, and pick the next one. Now: - The first points of a session are still collected and confirmed together. - After 确认 pick mode stays on. Every further click goes straight into the annotation list (no pending stage) and focuses the new point's note box; the instruction box stays editable throughout. Pressing 选点 again later continues the same list. - The pick bar switches to "继续点击模型,新位置直接加入标注 · 共 N 处" with 撤销上一个 (last point of this session; also Backspace) and 完成 (also Esc). - A collapsed annotation panel reopens when a point is added; while picking, the panel leaves room for the pick bar (also on narrow screens). - ⌘Z restores which points exist but keeps notes written since (points carry an in-page id; not persisted). Headless Chrome, 1400 px and 800 px: 19/19 each. npm run check: cq-viewer OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
plugins/hanzijie/cq-viewer1.2.0 — pick and annotate in one continuous flow.Before: 确认 turned pick mode off. Re-entering pick mode collected new points as "pending" again and needed another 确认, so once the annotation panel was open you could not pick a point, write its note, and pick the next one.
Now:
继续点击模型,新位置直接加入标注 · 共 N 处with 撤销上一个 (last point of this session, alsoBackspace) and 完成 (alsoEsc). Pressing 选点 later continues the same list without a confirm step; after 清空标注 the confirm step returns.bottom: 72px).⌘Znow restores which points exist but keeps notes written in between (points carry an in-page id, never persisted). Before, undoing an add after editing an earlier note reverted that note.No server, MCP, or file-access changes. Version strings bumped together (test checks).
Checks
npm run check:plugins/hanzijie/cq-viewer: OK— 0 errors, 0 warnings; 55/55.node --test plugins/hanzijie/cq-viewer/tests/*.test.mjs: 19/19.Backspace,⌘Z(keeps edited notes),Esc×2, 完成; re-entering continues without confirm; collapsed panel reopens; after 清空标注 confirm returns;selection.jsoncontains points, notes and instruction.Tested environment
MiniMax Code
3.1.1-preview.4597, macOS 26 (Apple Silicon): installed locally and opened. The continuous flow itself was exercised in headless Chrome only.Not verified
Need help on this PR? Tag
@codesmith-botwith what you need.