Repository navigation
fix: let Moonbase decide whether a release can be downloaded - #49
Merged
Merged
Conversation
The update screen judged download permission on the device from two of Moonbase's rules: owning the product and being a signed-in customer. A release limited to a group of customers, or to none, was still offered, and Moonbase then refused the download. The release endpoint already says whether this customer may download the release (downloadsAllowed). release_info now reads it and can_download uses it, keeping the device's rules only for a Moonbase that doesn't send it. download_needs_full_license says whether activating a full license would lift a refusal, and the JUCE update screen offers "Unlock full version" only then; otherwise it says the license can't download the update, and the notes take the empty button slot.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
downloads_allowed and needsFullLicense were inserted mid-struct, which would shift a positional brace initializer written against the earlier release_info or UpdateInfo. Both now sit at the end, as earlier fields were added. download_needs_full_license could also promise that a full license unlocks a release limited to a group of customers, which buying doesn't join. It now reads downloadsNeedsGroupMembership and returns false for such a release.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
## [4.13.2](v4.13.1...v4.13.2) (2026-10-28) ### Bug Fixes * let Moonbase decide whether a release can be downloaded ([#49](#49)) ([93e13ac](93e13ac))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update screen judged download permission on the device from two of Moonbase's rules (owning the product, being a signed-in customer), so a release limited to a group of customers, or to none, was offered and then refused at download.
get_releasenow reads Moonbase's own answer (downloadsAllowed) andcan_downloaduses it, keeping the device's rules only for a Moonbase that doesn't send it. A newdownload_needs_full_license(surfaced asupdateInfo().needsFullLicense) says whether activating a full license would help: the JUCE update screen offers "Unlock full version" only then, and otherwise says the license can't download the update, with the notes taking the empty button slot (new snapshot14c-update-not-allowed). Tested with new core and JUCE controller tests (213 and 166 cases pass on macOS), a render of the update snapshots, and a check that the demo tenant sendsdownloadsAllowed.