Repository navigation
chore(server): remove unused server macros crate - #4818
Merged
TaylorMutch merged 1 commit intoOct 22, 2026
Merged
Conversation
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
drew
approved these changes
Oct 22, 2026
Collaborator
Author
|
/ok to test 0af98da |
TaylorMutch
approved these changes
Oct 22, 2026
crm00re
added a commit
to crm00re/OpenShell
that referenced
this pull request
Oct 22, 2026
Resolve conflicts from the Rust SDK transport refactor (NVIDIA#4817) and the server-macros crate removal (NVIDIA#4818): - grpc_client keeps the SDK's channel construction (TLS discovery, edge tunnel, insecure mode) and re-attaches the CLI's GatewayInterceptor composing auth headers with W3C trace-context forwarding, using the SDK's re-exported raw gRPC client. The CLI never wires an OIDC refresher, so composing the interceptor client-side loses nothing from OpenShellClient::connect. - Drop the stale tls_server_name helper and tests; upstream moved server-name normalization into the SDK transport. - Cargo.lock: remove the deleted openshell-server-macros entry and regenerate for consistency. Signed-off-by: Chris Moore <cmoore@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused
openshell-server-macroscrate so workspace builds stop compiling obsolete authorization macros and contributor guidance points to the current proto authorization mechanism.Related Issue
Closes #4815
Changes
Cargo.lockentry.AGENTS.mdarchitecture row and update the core descriptor-set comment to referenceopenshell.options.v1.authorization.CONTRIBUTING.md; no stale references remain there.Release Notes
Testing
mise run rust:lint, Markdown lint, andgit diff --check.Checklist