[rwgk]

Description

Following the discussion of #2737, the team requested a staged approach to supporting multiple CUDA bindings release lines on main (#1199). This PR is the first preparatory step: give the existing CUDA 13 source root an explicit versioned name and update the plumbing that depends on it.

This PR renames the CUDA 13 bindings source directory from cuda_bindings/ to cuda_bindings_13/, and updates the build, test, CI, documentation, and tooling paths that refer to it.

Package names, Python imports, generated bindings, and the sample and benchmark directory names stay the same. The shared build-helper symlink is retargeted to the new directory, and release documentation retains support for locating the source root in older tags.

This is a standalone PR targeting main. It uses the checkout-aware Lychee support merged in #3143 to validate repository links to the renamed directory before that directory exists on the default branch. This is a new iteration of #3116, which remains unchanged for reference.

Review aid

Most of the diff consists of the directory move and repeated path substitutions. A two-commit review branch, built from the same main base as this PR revision, makes the other adjustments easier to inspect. Read these two views in order:

1. Changes with mechanical text substitutions removed. Compares against the captured main base after replacing cuda_bindings_13 with cuda_bindings in file contents and symlink targets; all file and directory paths stay as in this PR.
2. Mechanical text substitutions only. Shows the literal substitutions that restore the proposed source-root name. The final commit's Git tree was verified to match the linked PR revision exactly.

Directory moves remain visible in the first view. The intermediate commit is for review only and is not expected to build. Paths, modes, and contents were independently checked across all 1,158 tracked entries; normalization changes 61 blobs and 156 occurrences.

This review comment explains the changes in ci/tools/tests/test_build_docs_for_link_check.py, including why the test now executes the helper's import checks.

Validation

For the current standalone revision, after merging main at b288fc81fed8:

• The merge was conflict-free. Confirmed that the rename patch against updated main is identical to the preceding revision, and that incoming changes from main are preserved exactly. No additional rename adjustments were needed.
• Focused tests in the existing TestVenv: 265 passed, plus 36 subtests (259 CI-tool tests and the six incoming child-process helper tests).
• Full local pre-commit run --all-files --show-diff-on-failure: passed.
• Verified both review-aid comparisons on GitHub and exact equality of the published final tree with the PR tree.

Earlier end-to-end validation, before the subsequent main refreshes:

• Independently reconstructed the rename on the same base and reconciled both implementations to an identical Git tree.
• Fresh CUDA 13.4 TestVenv builds and QA suites passed: Pathfinder, bindings in both default-stream modes, Core, and both Cython suites.
• Full CI passed. One Windows job was retried after a results-upload timeout; its tests had passed.

The full CI matrix has not been rerun for the current revision.

Checklist

• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[rwgk]

/ok to test ba4ebf1

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.

[rwgk]

codex GPT-6.1-Sol ultra explanation for the changes in this file:

These changes make the existing docs-helper test exercise the source-directory mapping affected by this PR.

The helper checks that cuda.bindings, cuda.core, and cuda.pathfinder are imported from this checkout and that their versions agree with installed distribution metadata. Previously, it inferred each source directory from the distribution name by replacing hyphens with underscores. That inference stops working for bindings after this rename:

Distribution:     cuda-bindings
Python import:    cuda.bindings
Source directory: cuda_bindings_13

The helper now records the source directories explicitly. To cover that change, this test needs to execute the helper's import checks.

Previously, the test's fake python executable intercepted python - (execute a program from standard input), discarded the program with cat >/dev/null, and returned success. That bypassed the entire import-checking block. Leaving that stub in place would let the test pass even if the helper still expected the old cuda_bindings/ directory.

The added setup creates minimal Python packages under the expected source directories, supplies matching .dist-info/METADATA, and exposes those directories through PYTHONPATH. Removing the python - interception then lets the real interpreter execute the helper's checks against this temporary checkout.

Package installation remains stubbed out, and documentation generation remains simulated, so the test still runs without CUDA or Sphinx. Its existing assertions about the docs domain and copied output remain in place; it now also fails if the helper uses the wrong source directory.

[coderabbitai]

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Summary

Summary by CodeRabbit

• Chores
  • Updated project workflows, documentation, and development tooling to recognize the CUDA bindings package under its versioned name.
  • Preserved support for other packages and existing build and test behavior.

References to the CUDA bindings source directory now use cuda_bindings_13 across package integration, build and test workflows, CI tooling, and repository configuration. The documentation workflow prefers this directory and falls back to cuda_bindings.

Changes: Bindings source-path update

Layer / File(s)	Summary
Package paths and shared build integration cuda_bindings_13/*, cuda_core/*, cuda_python/*, cuda_python_test_helpers/*	Package documentation, shared build paths, local dependencies, and source-based tests now reference cuda_bindings_13.
Build and test workflows .github/workflows/*, pixi.toml, pytest.ini	Documentation, wheel, source-distribution, coverage, and source-test workflows use the versioned directory. The docs workflow prefers cuda_bindings_13, falls back to cuda_bindings, and fails if neither exists.
CI planning and validation tooling ci/tools/*, ci/README.md	CI scripts and test fixtures use cuda_bindings_13 paths. PACKAGE_MODULES now defines four package-to-module mappings explicitly.
Repository configuration and path references .coderabbit.yaml, .github/labeler.yml, .gitignore, .pre-commit-config.yaml, AGENTS.md, CONTRIBUTING.md, README.md, benchmarks/*, context7.json, ruff.toml, toolshed/*	Guidance, filters, ignore patterns, lint rules, and development tooling point to cuda_bindings_13.

Suggested reviewers: mdboom, juenglin, andy-jost

Priority: ⬇️ Low

Change: Refactor

Merge Risk: 🔵 Low · up to ba4eb

Update the two lockfiles and preserve generated-file seal checks across the rename. The identified gaps are bounded, but should be addressed before merging.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 39093a49-fecc-4a59-8b55-d92ef1a9cb2b

📥 Commits

Reviewing files that changed from the base of the PR and between 983ac75 and ba4ebf1.

⛔ Files ignored due to path filters: 4

• benchmarks/cuda_bindings/pixi.lock is excluded by !**/*.lock
• cuda_bindings_13/docs/source/_static/images/Nsight-Compute-CLI-625x473.png is excluded by !**/*.png
• cuda_bindings_13/pixi.lock is excluded by !**/*.lock
• cuda_core/pixi.lock is excluded by !**/*.lock

📒 Files selected for processing: 285

• .coderabbit.yaml
• .github/labeler.yml
• .github/workflows/build-docs.yml
• .github/workflows/build-wheel.yml
• .github/workflows/ci-pixi-source-test.yml
• .github/workflows/ci.yml
• .github/workflows/coverage.yml
• .github/workflows/test-sdist-linux.yml
• .github/workflows/test-sdist-windows.yml
• .gitignore
• .pre-commit-config.yaml
• AGENTS.md
• CONTRIBUTING.md
• README.md
• benchmarks/cuda_bindings/AGENTS.md
• benchmarks/cuda_bindings/pixi.toml
• benchmarks/cuda_core/pixi.toml
• ci/README.md
• ci/tools/build_docs_for_link_check.sh
• ci/tools/check_pixi_cuda_version.py
• ci/tools/check_release_notes.py
• ci/tools/compute_ci_plan.py
• ci/tools/env-vars
• ci/tools/run-tests
• ci/tools/tests/test_build_docs_for_link_check.py
• ci/tools/tests/test_check_release_notes.py
• ci/tools/tests/test_compute_ci_plan.py
• context7.json
• cuda_bindings_13/.git_archival.txt
• cuda_bindings_13/AGENTS.md
• cuda_bindings_13/CLAUDE.md
• cuda_bindings_13/DESCRIPTION.rst
• cuda_bindings_13/LICENSE
• cuda_bindings_13/MANIFEST.in
• cuda_bindings_13/README.md
• cuda_bindings_13/_build_shared.py
• cuda_bindings_13/build_hooks.py
• cuda_bindings_13/cuda/bindings/__init__.pxd
• cuda_bindings_13/cuda/bindings/__init__.py
• cuda_bindings_13/cuda/bindings/_internal/__init__.py
• cuda_bindings_13/cuda/bindings/_internal/_fast_enum.py
• cuda_bindings_13/cuda/bindings/_internal/cudla.pxd
• cuda_bindings_13/cuda/bindings/_internal/cudla_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/cudla_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/cufile.pxd
• cuda_bindings_13/cuda/bindings/_internal/cufile_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/driver.pxd
• cuda_bindings_13/cuda/bindings/_internal/driver_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/driver_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvfatbin.pxd
• cuda_bindings_13/cuda/bindings/_internal/nvfatbin_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvfatbin_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvjitlink.pxd
• cuda_bindings_13/cuda/bindings/_internal/nvjitlink_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvjitlink_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvml.pxd
• cuda_bindings_13/cuda/bindings/_internal/nvml_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvml_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvrtc.pxd
• cuda_bindings_13/cuda/bindings/_internal/nvrtc_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvrtc_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvvm.pxd
• cuda_bindings_13/cuda/bindings/_internal/nvvm_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/nvvm_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/runtime.pxd
• cuda_bindings_13/cuda/bindings/_internal/runtime_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/runtime_ptds.pxd
• cuda_bindings_13/cuda/bindings/_internal/runtime_ptds_linux.pyx
• cuda_bindings_13/cuda/bindings/_internal/runtime_ptds_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/runtime_windows.pyx
• cuda_bindings_13/cuda/bindings/_internal/utils.pxd
• cuda_bindings_13/cuda/bindings/_internal/utils.pyx
• cuda_bindings_13/cuda/bindings/_lib/__init__.py
• cuda_bindings_13/cuda/bindings/_lib/cyruntime/cyruntime.pxd
• cuda_bindings_13/cuda/bindings/_lib/cyruntime/cyruntime.pxi
• cuda_bindings_13/cuda/bindings/_lib/dlfcn.pxd
• cuda_bindings_13/cuda/bindings/_lib/utils.pxd
• cuda_bindings_13/cuda/bindings/_lib/utils.pxi
• cuda_bindings_13/cuda/bindings/_lib/windll.pxd
• cuda_bindings_13/cuda/bindings/_v2/__init__.py
• cuda_bindings_13/cuda/bindings/_v2/nvrtc.pxd
• cuda_bindings_13/cuda/bindings/_v2/nvrtc.pyx
• cuda_bindings_13/cuda/bindings/cudla.pxd
• cuda_bindings_13/cuda/bindings/cudla.pyx
• cuda_bindings_13/cuda/bindings/cufile.pxd
• cuda_bindings_13/cuda/bindings/cufile.pyx
• cuda_bindings_13/cuda/bindings/cycudla.pxd
• cuda_bindings_13/cuda/bindings/cycudla.pyx
• cuda_bindings_13/cuda/bindings/cycufile.pxd
• cuda_bindings_13/cuda/bindings/cycufile.pyx
• cuda_bindings_13/cuda/bindings/cydriver.pxd
• cuda_bindings_13/cuda/bindings/cydriver.pyx
• cuda_bindings_13/cuda/bindings/cynvfatbin.pxd
• cuda_bindings_13/cuda/bindings/cynvfatbin.pyx
• cuda_bindings_13/cuda/bindings/cynvjitlink.pxd
• cuda_bindings_13/cuda/bindings/cynvjitlink.pyx
• cuda_bindings_13/cuda/bindings/cynvml.pxd
• cuda_bindings_13/cuda/bindings/cynvml.pyx
• cuda_bindings_13/cuda/bindings/cynvrtc.pxd
• cuda_bindings_13/cuda/bindings/cynvrtc.pyx
• cuda_bindings_13/cuda/bindings/cynvvm.pxd
• cuda_bindings_13/cuda/bindings/cynvvm.pyx
• cuda_bindings_13/cuda/bindings/cyruntime.pxd
• cuda_bindings_13/cuda/bindings/cyruntime.pyx
• cuda_bindings_13/cuda/bindings/driver.pxd
• cuda_bindings_13/cuda/bindings/driver.pyx
• cuda_bindings_13/cuda/bindings/nvfatbin.pxd
• cuda_bindings_13/cuda/bindings/nvfatbin.pyx
• cuda_bindings_13/cuda/bindings/nvjitlink.pxd
• cuda_bindings_13/cuda/bindings/nvjitlink.pyx
• cuda_bindings_13/cuda/bindings/nvml.pxd
• cuda_bindings_13/cuda/bindings/nvml.pyx
• cuda_bindings_13/cuda/bindings/nvrtc.pxd
• cuda_bindings_13/cuda/bindings/nvrtc.pyx
• cuda_bindings_13/cuda/bindings/nvvm.pxd
• cuda_bindings_13/cuda/bindings/nvvm.pyx
• cuda_bindings_13/cuda/bindings/runtime.pxd
• cuda_bindings_13/cuda/bindings/runtime.pyx
• cuda_bindings_13/cuda/bindings/utils/__init__.py
• cuda_bindings_13/cuda/bindings/utils/_envvar.py
• cuda_bindings_13/cuda/bindings/utils/_nvvm_utils.py
• cuda_bindings_13/cuda/bindings/utils/_ptx_utils.py
• cuda_bindings_13/cuda/bindings/utils/_version_check.py
• cuda_bindings_13/docs/Makefile
• cuda_bindings_13/docs/README.md
• cuda_bindings_13/docs/build_docs.sh
• cuda_bindings_13/docs/make.bat
• cuda_bindings_13/docs/nv-versions.json
• cuda_bindings_13/docs/source/_templates/main.html
• cuda_bindings_13/docs/source/api.rst
• cuda_bindings_13/docs/source/conduct.rst
• cuda_bindings_13/docs/source/conf.py
• cuda_bindings_13/docs/source/contribute.rst
• cuda_bindings_13/docs/source/environment_variables.rst
• cuda_bindings_13/docs/source/examples.rst
• cuda_bindings_13/docs/source/index.rst
• cuda_bindings_13/docs/source/install.rst
• cuda_bindings_13/docs/source/license.rst
• cuda_bindings_13/docs/source/module/cudla.rst
• cuda_bindings_13/docs/source/module/cufile.rst
• cuda_bindings_13/docs/source/module/driver.rst
• cuda_bindings_13/docs/source/module/nvfatbin.rst
• cuda_bindings_13/docs/source/module/nvjitlink.rst
• cuda_bindings_13/docs/source/module/nvml.rst
• cuda_bindings_13/docs/source/module/nvrtc.rst
• cuda_bindings_13/docs/source/module/nvvm.rst
• cuda_bindings_13/docs/source/module/runtime.rst
• cuda_bindings_13/docs/source/module/utils.rst
• cuda_bindings_13/docs/source/motivation.rst
• cuda_bindings_13/docs/source/overview.rst
• cuda_bindings_13/docs/source/release.rst
• cuda_bindings_13/docs/source/release/11.4.0-notes.rst
• cuda_bindings_13/docs/source/release/11.5.0-notes.rst
• cuda_bindings_13/docs/source/release/11.6.0-notes.rst
• cuda_bindings_13/docs/source/release/11.6.1-notes.rst
• cuda_bindings_13/docs/source/release/11.7.0-notes.rst
• cuda_bindings_13/docs/source/release/11.7.1-notes.rst
• cuda_bindings_13/docs/source/release/11.8.0-notes.rst
• cuda_bindings_13/docs/source/release/11.8.1-notes.rst
• cuda_bindings_13/docs/source/release/11.8.2-notes.rst
• cuda_bindings_13/docs/source/release/11.8.3-notes.rst
• cuda_bindings_13/docs/source/release/11.8.4-notes.rst
• cuda_bindings_13/docs/source/release/11.8.5-notes.rst
• cuda_bindings_13/docs/source/release/11.8.6-notes.rst
• cuda_bindings_13/docs/source/release/11.8.7-notes.rst
• cuda_bindings_13/docs/source/release/12.0.0-notes.rst
• cuda_bindings_13/docs/source/release/12.1.0-notes.rst
• cuda_bindings_13/docs/source/release/12.2.0-notes.rst
• cuda_bindings_13/docs/source/release/12.2.1-notes.rst
• cuda_bindings_13/docs/source/release/12.3.0-notes.rst
• cuda_bindings_13/docs/source/release/12.4.0-notes.rst
• cuda_bindings_13/docs/source/release/12.5.0-notes.rst
• cuda_bindings_13/docs/source/release/12.6.0-notes.rst
• cuda_bindings_13/docs/source/release/12.6.1-notes.rst
• cuda_bindings_13/docs/source/release/12.6.2-notes.rst
• cuda_bindings_13/docs/source/release/12.8.0-notes.rst
• cuda_bindings_13/docs/source/release/12.9.0-notes.rst
• cuda_bindings_13/docs/source/release/12.9.1-notes.rst
• cuda_bindings_13/docs/source/release/12.9.2-notes.rst
• cuda_bindings_13/docs/source/release/12.9.3-notes.rst
• cuda_bindings_13/docs/source/release/12.9.4-notes.rst
• cuda_bindings_13/docs/source/release/12.9.5-notes.rst
• cuda_bindings_13/docs/source/release/12.9.6-notes.rst
• cuda_bindings_13/docs/source/release/12.9.7-notes.rst
• cuda_bindings_13/docs/source/release/12.9.8-notes.rst
• cuda_bindings_13/docs/source/release/12.9.9-notes.rst
• cuda_bindings_13/docs/source/release/13.0.0-notes.rst
• cuda_bindings_13/docs/source/release/13.0.1-notes.rst
• cuda_bindings_13/docs/source/release/13.0.2-notes.rst
• cuda_bindings_13/docs/source/release/13.0.3-notes.rst
• cuda_bindings_13/docs/source/release/13.1.0-notes.rst
• cuda_bindings_13/docs/source/release/13.1.1-notes.rst
• cuda_bindings_13/docs/source/release/13.2.0-notes.rst
• cuda_bindings_13/docs/source/release/13.3.0-notes.rst
• cuda_bindings_13/docs/source/release/13.3.1-notes.rst
• cuda_bindings_13/docs/source/release/13.4.0-notes.rst
• cuda_bindings_13/docs/source/release/13.4.0b1-notes.rst
• cuda_bindings_13/docs/source/release/13.4.1-notes.rst
• cuda_bindings_13/docs/source/release/13.4.1a0-notes.rst
• cuda_bindings_13/docs/source/release/13.4.2-notes.rst
• cuda_bindings_13/docs/source/release/13.4.3-notes.rst
• cuda_bindings_13/docs/source/release/13.5.0-notes.rst
• cuda_bindings_13/docs/source/support.rst
• cuda_bindings_13/docs/source/tips_and_tricks.rst
• cuda_bindings_13/docs/versions.json
• cuda_bindings_13/pixi.toml
• cuda_bindings_13/pyproject.toml
• cuda_bindings_13/setup.py
• cuda_bindings_13/tests/conftest.py
• cuda_bindings_13/tests/cudla/conftest.py
• cuda_bindings_13/tests/cudla/test_cudla_bindings.py
• cuda_bindings_13/tests/cufile.json
• cuda_bindings_13/tests/cython/build_tests.bat
• cuda_bindings_13/tests/cython/build_tests.py
• cuda_bindings_13/tests/cython/build_tests.sh
• cuda_bindings_13/tests/cython/test_ccuda.pyx
• cuda_bindings_13/tests/cython/test_ccudart.pyx
• cuda_bindings_13/tests/cython/test_cython.py
• cuda_bindings_13/tests/cython/test_interoperability_cython.pyx
• cuda_bindings_13/tests/example_tests/run_samples.py
• cuda_bindings_13/tests/example_tests/test_args.json
• cuda_bindings_13/tests/example_tests/test_cuda_bindings_utils.py
• cuda_bindings_13/tests/example_tests/test_interactive_sample_configuration.py
• cuda_bindings_13/tests/example_tests/test_samples.py
• cuda_bindings_13/tests/legacy_api/README.md
• cuda_bindings_13/tests/legacy_api/test_legacy_kernelParams.py
• cuda_bindings_13/tests/legacy_api/test_legacy_nvfatbin.py
• cuda_bindings_13/tests/legacy_api/test_legacy_nvjitlink.py
• cuda_bindings_13/tests/legacy_api/test_legacy_nvrtc.py
• cuda_bindings_13/tests/nvml/README.md
• cuda_bindings_13/tests/nvml/__init__.py
• cuda_bindings_13/tests/nvml/conftest.py
• cuda_bindings_13/tests/nvml/test_compute_mode.py
• cuda_bindings_13/tests/nvml/test_cuda.py
• cuda_bindings_13/tests/nvml/test_device.py
• cuda_bindings_13/tests/nvml/test_gpu.py
• cuda_bindings_13/tests/nvml/test_init.py
• cuda_bindings_13/tests/nvml/test_nvlink.py
• cuda_bindings_13/tests/nvml/test_page_retirement.py
• cuda_bindings_13/tests/nvml/test_pci.py
• cuda_bindings_13/tests/nvml/test_pynvml.py
• cuda_bindings_13/tests/nvml/test_unit.py
• cuda_bindings_13/tests/nvml/test_util.py
• cuda_bindings_13/tests/nvml/util.py
• cuda_bindings_13/tests/test_basics.py
• cuda_bindings_13/tests/test_build_hooks.py
• cuda_bindings_13/tests/test_cuda.py
• cuda_bindings_13/tests/test_cudart.py
• cuda_bindings_13/tests/test_cufile.py
• cuda_bindings_13/tests/test_envvar.py
• cuda_bindings_13/tests/test_graphics_apis.py
• cuda_bindings_13/tests/test_interoperability.py
• cuda_bindings_13/tests/test_kernelParams.py
• cuda_bindings_13/tests/test_nvfatbin.py
• cuda_bindings_13/tests/test_nvjitlink.py
• cuda_bindings_13/tests/test_nvrtc.py
• cuda_bindings_13/tests/test_nvvm.py
• cuda_bindings_13/tests/test_utils.py
• cuda_bindings_13/tests/test_version_check.py
• cuda_bindings_13/tests/utils/check_cyclical_import.py
• cuda_core/AGENTS.md
• cuda_core/_build_shared.py
• cuda_core/build_hooks.py
• cuda_core/pixi.toml
• cuda_core/pyproject.toml
• cuda_core/tests/AGENTS.md
• cuda_core/tests/conftest.py
• cuda_core/tests/example_tests/test_sample_environment.py
• cuda_core/tests/test_build_hooks.py
• cuda_core/tests/test_driver_table.py
• cuda_core/tests/test_graphics.py
• cuda_core/tests/test_rt_layout.py
• cuda_python/AGENTS.md
• cuda_python/docs/build_all_docs.sh
• cuda_python_test_helpers/cuda_python_test_helpers/_pytest_plugin.py
• cuda_python_test_helpers/cuda_python_test_helpers/cython_cache.py
• cuda_python_test_helpers/cuda_python_test_helpers/graphics.py
• pixi.toml
• pytest.ini
• ruff.toml
• toolshed/build_static_bitcode_input.py
• toolshed/check_cython_not_none.py
• toolshed/check_generated_file_seals.py
• toolshed/check_spdx.py
• toolshed/find_skipped_tests.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

[mdboom]

My concern is still that this creates many places that will need to be updated when we bump 13->14 and 12->13. (My grep counts 155 such places). It is not /yet/ the case that updating ci/versions.yaml alone will handle most of that for us.

However, my agent assures me that most of these /can/ be updated to use a single source of truth. For those that /can't/ (hardcoded paths in yaml files or .gitignore etc) judicious use of wildcards may help us.

So I am approving this with the suggestion that maybe the next step should be adding the ci/versions.yml in the new form you proposed and removing as much hardcoding to cuda_bindings_13 as we can. The check will be with watching rg --hidden -o cuda_bindings_13 | wc -l, hopefully in the single digits.

The broken GitHub blob links (due to the directory rename) is a real issue, but also one that I think is not particularly important. There is a way we can avoid it going forward (see #3164), but I don't think we can fix it for links we have already made out in the wild. #3164 can be handled completely independently of this.

[rwgk]

Thanks for the approval!

My concern is still that this creates many places that will need to be updated when we bump 13->14 and 12->13. (My grep counts 155 such places). It is not /yet/ the case that updating ci/versions.yaml alone will handle most of that for us.

That is solved comprehensively in #2737.

This PR is deliberately a minimal mechanical step to — conceptually — set the stage for adding the content of #2737 on top. That will completely eliminate the renaming issue. I'll follow through with that with highest priority.

[rwgk]

/ok to test 991bbc8

[rwgk]

The broken GitHub blob links (due to the directory rename) is a real issue, but also one that I think is not particularly important. There is a way we can avoid it going forward (see #3164), but I don't think we can fix it for links we have already made out in the wild. #3164 can be handled completely independently of this.

Thanks also for opening #3164. Linking PyPI descriptions to the corresponding release tag makes sense and would keep those links stable across future source-directory moves. I'll keep this in mind as I bring over the changes from #2737 in layers. Please let me know if there's anything I can do to help coordinate the two efforts.

[juenglin]

A few spots where the mechanical cuda_bindings -> cuda_bindings_13 substitution landed on prose/comments that refer to the version-neutral cuda-bindings package or import rather than the renamed source directory. Non-blocking; flagging for clarity since the _13 suffix implies a version-specificity that doesn't exist at the package level.

[juenglin]

This dependency graph (lines 125-131) is package-level — it's "verified in pyproject.toml files" — and the cuda-bindings package/import is version-neutral. The _13 suffix is the source-directory name, so applying it to the package dependencies reads as if a version-specific package existed. Consider keeping these nodes as cuda_bindings while only filesystem paths take the _13 suffix.

[juenglin]

This pin parity is with the cuda-bindings package pin, not the source directory, so the _13 suffix is misleading here. Suggest "pinned to match cuda-bindings".

[juenglin]

"cuda_bindings graphics tests" refers to the bindings package's test suite sharing this helper, not the source directory, so _13 is misleading. Same applies on line 138.

[juenglin]

The shared build logic is a property of the cuda-bindings package/build backend. The real file path on line 28 correctly keeps _13, but here "Logic shared with cuda_bindings_13" reads as version-specific; consider cuda-bindings.

[juenglin]

"cuda_bindings test environments" is a package-level concept; _13 is the directory name. Suggest cuda-bindings here.

[juenglin]

This now reads as self-contradictory (cuda_bindings_13 ... "in its cu12 environment"). The statement is about the bindings package lacking a cu12 source build, so cuda.bindings/cuda-bindings is clearer than the _13 directory name.

[rwgk]

A few spots where the mechanical cuda_bindings -> cuda_bindings_13 substitution landed on prose/comments that refer to the version-neutral cuda-bindings package or import rather than the renamed source directory.

Thanks for catching those! I'll take care of them right after this PR lands. — Unfortunately the CI is super slow today, I think it'll best to use the almost complete CI here to get the big rename done.

[rwgk]

A few spots where the mechanical cuda_bindings -> cuda_bindings_13 substitution landed on prose/comments that refer to the version-neutral cuda-bindings package or import rather than the renamed source directory.

Thanks for catching those! I'll take care of them right after this PR lands. — Unfortunately the CI is super slow today, I think it'll best to use the almost complete CI here to get the big rename done.

The fixes were merged with PR #3165 (comment)