Repository navigation
bulk: check index type contract - #2359
Merged
Merged
Conversation
The index type is deduced from the Shape type. https://eel.is/c++draft/exec#bulk-4 Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
Contributor
Author
|
@ericniebler I have read the whole test file and couldn't see a test that validates this contract that the function is called with an index type whose type is the same as the |
ericniebler
approved these changes
Oct 23, 2026
Collaborator
|
/ok to test e5c151c |
Contributor
Author
|
@ericniebler Any idea for the CI failures? |
Collaborator
|
I am without a clue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index type is deduced from the Shape type.
I am not sure whether this can be turned into a pure compile-time test, because of the trailing
__well_formed_senderconstrain on the generic bulk call operator.Reference: