Repository navigation
Conversation
Contributor
|
Review of 4afe7c7: no bugs found. Checked:
|
The previous commit gates the NA51023 code on __mips__, which keeps it out of arm32 and arm64, but libipchw on MIPS still carries it: a MIPS ipcinfo with IPCHW_VENDORS=all grew by 88 bytes. No camera that ships ipcinfo is a MIPS Novatek, so the library must not pay for one. Every MIPS gate now also requires !STANDALONE_LIBRARY, including the detection row in chipid.c, so ipctool identifies the part and libipchw never compiles it. The novatek tests are built without STANDALONE_LIBRARY, as ipctool is, so they still exercise that code. ipcinfo is byte-identical to master on arm32, mips32 and arm64 with IPCHW_VENDORS=all and none.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIPS cameras identifying as
Novatek NA51023currently miss Novatek detection. Add a dedicated MIPS detector for the complete model token, report familynt9851x, and refine the name toNT98513only when/etc/profile_prjcfgcontains the exactexport CHIP="98513"declaration. Missing or different profiles retainNA51023. The profile is parsed as text. Other model tokens and the unverified ARM chip-ID proc interface cannot select this MIPS route.The identity is backed by an NT98513 firmware dump's embedded model,
novatek,na51023-soccompatible and factory CHIP declaration. The software discriminator selects a HAL that declines unsupported sensor-bus operations. This adds identification only; no camera was available to validate boot or capture.The new refinement, family case and HAL behavior are compiled only for MIPS. Existing ARM/AArch64 parsing and behavior are preserved. With the exact ARM32 CI SDK and firmware-style size configuration, both
ipcinfovariants are byte-for-byte identical to the PR base: 47,356 bytes for all vendors and 38,492 for none. The size allowance is unchanged.Tests use the actual parser, detector and platform dispatch, covering complete-token rejection, missing/mismatched profiles, ARM-ID isolation, legacy chip IDs and rejected sensor probing. Three explicit architecture fixtures run in native CI. Validation passed: full native and MIPS builds, all 13 native tests, sensor extraction pipeline/self-tests, three architecture fixtures under ASan/UBSan, and all three fixtures as MIPS binaries under QEMU. The local MIPS compiler is Debian GCC 12, MIPS32r2 o32 hard-float glibc; this does not establish compatibility with the camera's soft-float uClibc runtime.