Repository navigation
Drop the unused netty-reactive-streams jars - #507
Open
tonygermano wants to merge 1 commit into
Open
tonygermano wants to merge 1 commit into
tonygermano wants to merge 1 commit into
Conversation
The com.typesafe.netty netty-reactive-streams and netty-reactive-streams-http 2.0.8 jars in aws/ext/netty hold an implementation of the Reactive Streams interfaces for Netty. netty-nio-client includes its own copy of that implementation under software.amazon.awssdk.http.nio.netty.internal.nrs, credited in its NOTICE, so the separate jars are no longer used. The copy covers every class of the two jars except the server and WebSocket ones (HttpStreamsServerHandler, WebSocketHttpResponse and DefaultWebSocketHttpResponse), which an HTTP client does not need. No class in any other jar of the distribution references com.typesafe.netty, and no service or configuration file names it. Remove them from the catalog, the server bundle and the vendored layout, and drop com.typesafe.netty from the Renovate netty group. reactive-streams stays: it holds the interfaces being implemented (Publisher, Subscriber, Subscription), which netty-nio-client and the SDK core still use. Checksums regenerated with a cold cache per CONTRIBUTING.md. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
requested review from
a team,
gibson9583,
kayyagari,
kpalang and
ssrowe
October 23, 2026 11:38
mgaffigan
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server ships
com.typesafe.netty:netty-reactive-streamsandnetty-reactive-streams-http2.0.8 inserver-lib/aws/ext/netty, but nothing uses them. They hold an implementation of the Reactive Streams interfaces for Netty, and the AWS SDK's netty-nio-client includes its own copy of that implementation undersoftware.amazon.awssdk.http.nio.netty.internal.nrs, credited in its NOTICE. The copy covers every class of the two jars except the server and WebSocket ones (HttpStreamsServerHandler,WebSocketHttpResponse,DefaultWebSocketHttpResponse), which an HTTP client doesn't need. This PR removes the two jars.gradle/libs.versions.toml: removes the version, both libraries and their server bundle entries.gradle/vendored-layout.json: removes theiraws/ext/nettymappings.renovate.json: dropscom.typesafe.netty*from the netty group, since nothing matches it any more.gradle/verification-metadata.xml: regenerated with a cold cache, as CONTRIBUTING.md describes. The only change is the three removedcom.typesafe.nettyentries (the two jars and the parent POM).org.reactivestreams:reactive-streamsstays: it holds the interfaces being implemented (Publisher,Subscriber,Subscription), which netty-nio-client and the SDK core still use.This is independent of #506. netty-nio-client 2.20.140 (on
main) and 2.55.12 (in #506) both use their internal copy and reference nothing incom.typesafe.netty. The two PRs touch nearby lines inlibs.versions.tomlandverification-metadata.xml, so whichever merges second may need a rebase.Testing
Claude checked:
./gradlew clean build dist: all 722 tests pass.main: none referencescom/typesafe/netty. NoMETA-INF/servicesfile, configuration file or nested archive names it either.com/typesafe/netty.server-lib/aws/ext/nettyno longer contains the two jars and is otherwise unchanged.Release notes
server-lib/aws/ext/netty.🤖 Drafted with Claude Code