Align the pull request template with the ending block structure PR Format requires #40

Activity

1. Marius Storhaug (MariusStorhaug)

   added

   NoRelease

   on Aug 2, 2026
2. MariusStorhaug commented on Aug 2, 2026

   

   Marius Storhaug (MariusStorhaug)

   on Aug 2, 2026

   MemberAuthor

   More actions

   Swept the organization to size this. Every PSModule repository is affected, and the cause is datable.

   96 of 96 repositories with a .github/pull_request_template.md carry the pre-change structure. Zero conform. The sweep matched on the Relevant issues summary text:

   $repos = gh repo list PSModule --limit 100 --json name --jq '.[].name'
   foreach ($r in $repos) {
       $t = gh api "repos/PSModule/$r/contents/.github/pull_request_template.md" -H "Accept: application/vnd.github.raw" 2>$null
       if ($t -and ($t -join "`n") -notmatch 'Relevant issues') { $r }
   }

   This is not neglect — it is a standard change that never propagated. The ending-block structure was introduced in MSXOrg/docs#95, commit f3aede8, on 2026-07-25. Every template in the organization predates it, so all 96 were correct when they were written and none were updated when the standard moved.

   That reframes this issue in two ways:

   • The blast radius is the whole organization, not this repository. Fixing .github/pull_request_template.md here is still the right root fix, because the other 95 inherit from it — but the fix only reaches them through whatever propagation this template has, and that propagation is what needs confirming as part of closing this.
   • The underlying gap is systemic. A normative structure changed in the standards repository with no step that updated the artifacts embodying it. Raised separately as MSXOrg/docs#143, since the fix there is a process change rather than a template edit.

   One detail worth carrying into the fix: the drift is not cosmetic. ## Technical Details renders as a visible body section, so implementation detail lands in the middle of what PR Format defines as the release note. Every PR opened from this template puts reviewer-facing content in front of users.
3. MariusStorhaug commented on Oct 31, 2026

   

   Marius Storhaug (MariusStorhaug)

   on Oct 31, 2026

   MemberAuthor

   More actions

   Verified the current default tree at ff935a5: the recursive tree is complete and contains no local PR template. Template-PSModule therefore relies on the PSModule organization fallback rather than inheriting a copied file from its own source tree. PSModule/.github#82, scoped by native Task PSModule/.github#81, aligns that organization-owned fallback with the complete source candidate in MSXOrg/docs#209.

   This does not justify recreating the deleted local file or closing this issue solely because its old target is absent. Its acceptance criteria should be reconciled around the inherited fallback outcome and any remaining evidence of propagation to repositories that retain local copies. The historical 96-repository observation is not current rollout verification. The organization fallback PR closes only its own Task; this issue stays open, and no consumer fleet or duplicate template is introduced.
4. MariusStorhaug commented on Oct 31, 2026

   

   Marius Storhaug (MariusStorhaug)

   on Oct 31, 2026

   MemberAuthor

   More actions

   User-directed distribution reversal: the user selected "Remove central defaults too; use canonical PR-format guidance only" after requesting that no repository contain the PR-template file. The existing scoped PSModule/.github#82 and native Task PSModule/.github#81 are now revised to delete the central .github/pull_request_template.md outright, remove automatic-fallback claims, and retain only canonical authoring links. No local or central replacement is added.

   This supersedes the earlier comment's inheritance-based proposed outcome; old scaffold-copy evidence is history, not current distribution authority. The no-file default already observed in Template-PSModule should not be reversed by recreating its deleted local template. This issue remains open for owner reconciliation of its old file-target acceptance criteria and any genuinely remaining repository-copy removal scope, not closure merely because the original path is absent. No consumer fleet or Feature/Bug issue-form change is performed in the central removal PR.