Repository navigation
Conversation
warwickschroeder
requested changes
Oct 23, 2026
warwickschroeder
left a comment
warwickschroeder
left a comment
Contributor
There was a problem hiding this comment.
Two things im not sure about:
- the default schema naming
- Throwing if error and audit are on the same schema without a very good reason.
| | `Storage.BodyStorage.Type` | `RavenAttachments`, `FileSystem`, `AzureBlob`, `S3` | the persister | 6.20.0 | | ||
| | `Limits.MaxBodySizeToStore` | bytes | `MaxBodySizeToStore`, SQL Server and PostgreSQL only | 6.20.0 | | ||
| | `Storage.Schema` | `Default`, `Custom` | `Database/Schema`, SQL Server and PostgreSQL only | Unreleased | | ||
| | `Storage.Schema` | `Default` when the schema is `sc`, `Custom` for other configured schemas | `Database/Schema`, SQL Server and PostgreSQL only | Unreleased | |
Contributor
There was a problem hiding this comment.
Will also need to update the docs PR
warwickschroeder
approved these changes
Oct 23, 2026
Member
|
Shouldn't this be up to the user to decide? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate primary and audit SQL schemas
Why
The schema default was to share the same schema, however there was no testing that ensures this is actually supported.
For SQL Server and PostgreSQL:
Database/Schematopsw_scfor primary instances andpsw_auditfor audit instances when the setting is absent or blank.__AuditMigrationsHistory; audit instances reject__EFMigrationsHistory.Custom schema names remain supported. Operators must create the schema and grant the configured user rights before running setup. Setup does not create schemas or move data.
Update persistence manifests, default-schema telemetry, and documentation to match.