Repository navigation
feat(collabora): hold the page together between the Figma frames; share one page rhythm - #205
Draft
viganogabriele wants to merge 2 commits into
Draft
viganogabriele wants to merge 2 commits into
viganogabriele wants to merge 2 commits into
Conversation
Storia, Su di noi, Struttura, Team and Unisciti each spaced their sections differently (144 to 288px between sections at 1728, hero titles between y=224 and y=282). They now share PAGE_MAIN and PAGE_HERO from components/layout/page.ts, measured on the Figma frames: - 180px between section blocks from xl (Figma, Su di noi and Storia), 128px on tablets, 96px on phones; the same space before the footer. - Hero title at y=286 on desktop as in every Figma frame, with ~270px of air after the hero instead of the regular gap. Unisciti and Team had stretched their gaps (224-288px) to make up for sections that are shorter than in Figma; that space now follows the shared rule instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
/collabora matched Figma at 1728px but fell apart elsewhere: everything stacked below 1440px with a 719px column and half the screen empty, the contact steps stayed vertical up to 1615px, and the copy ran in 24px Poppins on tablets. - Shared container, section titles and rhythm (PAGE_MAIN/PAGE_HERO) of the other redesigned pages instead of the page's own 145px-gutter frame and per-section paddings. - Copy steps 16 → 20 → 24px (Figma size from 3xl) and stays left-aligned; the wide "Cosa possiamo fare insieme?" paragraph narrows to ~65 characters below 3xl. Line breaks forced for the 1728px frame are gone. - Figures: one row of four on laptops, two on tablets, Figma's 2×2 beside the copy from xl; cards size to their content. - Photo sections side by side from lg (Figma's 719:611 ratio, centred); stacked below with the photo as wide as the copy. - Contact steps in a row from lg with flexible cards; the e-mail step is a mailto link and the only card that reacts to hover. - InfoCard: optional titleClassName. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seventh step of the visual refinement. This PR is stacked on #204 (Unisciti), which is stacked on #203 → #202 → #201 → #200 → #199. Review and merge them in order. The diff below is relative to
feat/join-visual-refinement.Two commits:
/collabora(Figma desktop5248:13597, mobile5246:13012).1. Shared rhythm (
refactor(layout))Each earlier PR spaced its page differently:
components/layout/page.tsnow exportsPAGE_MAINandPAGE_HERO. Their values come from the Figma frames:The rhythm is applied to Storia, Su di noi, Struttura, Team, Unisciti and Collabora.
2. Collabora
At 1728 the page matched Figma, but it broke at every width Figma doesn't draw:
Container, titles and rhythm
Copy
3xl(1440). It is left-aligned at every width, like the other pages; the Figma mobile frame centres it.3xl. At 20 px it would have run to about 90.<br>tags that only showed from 1728, and the one inside "1000+".Figures (18k+, 45k+…)
xl, Figma's 2×2 block next to the copy.3xl.Photo sections
lg, keeping Figma's 719:611 ratio, and vertically centred so a taller text column doesn't leave the photo hanging.lg, with the photo as wide as the copy instead of a narrower 611 px block.Contact steps
lgwith flexible cards. Titles are 24 px and may wrap; the address breaks after the "@".lgthe steps stay stacked at Figma's card width.mailto:link. It is the only card on the page that leads somewhere, so it is the only one with hover and focus.Unchanged
Shared changes and their reach
PAGE_MAIN/PAGE_HEROinlayout/page.tsSectionTitleusesSECTION_TITLE;sectionContainerClassremovedHighlightfrom this moduleInfoCard: optionaltitleClassNameScreenshots
Each image shows before and after, full page.
Collabora






E-mail step on hover (1440)

Shared rhythm



Verification
pnpm check: clean.pnpm build: passes.pnpm typecheck: passes.node --test tests/*.test.mjs: 2/2 pass.Trade-offs
lgare about 220 px wide, so descriptions run to 3–4 short lines.Deliberately left out
Housekeeping
The screenshots live on the
pr-assets/collabora-visual-refinementbranch, which can be deleted after review.🤖 Generated with Claude Code