Repository navigation
feat(guides): align the guides hub and pages, drop the lorem placeholders - #212
Merged
BIA3IA merged 2 commits intoNov 2, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This was referenced Oct 28, 2026
viganogabriele
marked this pull request as ready for review
October 31, 2026 17:54
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 13:53
a56a7b3 to
bd337e9
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 13:53
f6f3d09 to
cf40915
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 14:06
bd337e9 to
e3378e4
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
2 times, most recently
from
November 2, 2026 14:20
d29f2c1 to
08e4f52
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 14:20
e3378e4 to
07c2fa0
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 14:32
08e4f52 to
f1d4032
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 14:32
07c2fa0 to
cc86268
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 14:35
f1d4032 to
42217ac
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 14:35
cc86268 to
0411096
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 14:56
42217ac to
aef988e
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 14:56
0411096 to
29dadc5
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 15:00
aef988e to
b8450f6
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
2 times, most recently
from
November 2, 2026 15:02
d08ebb6 to
7827987
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 15:02
b8450f6 to
5ce487d
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 15:14
7827987 to
3f49e8b
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
2 times, most recently
from
November 2, 2026 15:19
1e7680c to
568b424
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 15:19
3f49e8b to
2d04118
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 15:26
568b424 to
bb2a9f7
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 15:26
2d04118 to
49a9d5e
Compare
BIA3IA
force-pushed
the
feat/faqs-visual-refinement
branch
from
November 2, 2026 15:28
bb2a9f7 to
bc1dc7f
Compare
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 15:28
49a9d5e to
df6552b
Compare
Base automatically changed from
feat/faqs-visual-refinement
to
feat/home-visual-refinement
November 2, 2026 16:02
…ders
- /guides uses the shared container, rhythm and Hero, with Figma's subtitle
("Una raccolta di guide realizzate dai membri del Network"); the two
entry cards sit in an equal-height grid and react to hover, since they
are links.
- /guides/generali and the course result page drop the lorem ipsum guides
that were served in production and show their existing empty state
instead. GENERAL_GUIDES / COURSE_GUIDES are empty until the guide model
and content are decided.
- The back/close header and column of the wizard's end pages move from
groups/page-header to layout/flow-header (FlowHeader, FLOW_MAIN), shared
by groups and guides; the top padding on phones grows from 144 to 176px
so the title no longer sits 16px under the fixed header.
- EMPTY_STATE (the dashed placeholder) moves to layout/page and is used by
projects, associations, faqs, groups and guides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rses - FLOW_COLUMN builds on CONTAINER, so wizard result pages get the 64px gutter from lg like every other page instead of 40px. - The course step's empty list uses EMPTY_STATE, like the other lists this PR moved to it. - Comments trimmed; project-list imports sorted.
BIA3IA
force-pushed
the
feat/guides-visual-refinement
branch
from
November 2, 2026 16:03
df6552b to
b030678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #211:
feat/faqs-visual-refinement, the last layer of the stack that starts at #199. This is the last area of the page-by-page visual refinement:/guides,/guides/generaliand/guides/corso/**. Figma frames:1776:3073…1930:5103, mobile3409:9532/3409:11418.What changes
/guideshubHeroof the other redesigned pages.sm, capped at 896 px./guides/generaliand the course result pageGENERAL_GUIDES/COURSE_GUIDES, so the pages show the empty state that was already in the code ("Nessuna guida disponibile al momento")./guides/generalithe back and close buttons both went to/guides, so only back remains./guides/corsowizard is unchanged: it sharesWizardShellwith/groups, already refined in #208. I re-checked it at every width.Shared changes and their reach
groups/page-header.tsx→layout/flow-header.tsx(FlowHeader,FLOW_MAIN), now used by groups and guides/groups/extraand the group result pages: on phones the top padding goes from 144 to 176 px. Before, the title sat 16 px under the fixed header pill. Desktop is unchanged.EMPTY_STATEmoved tolayout/page.ts/projects,/associations,/faqs: identical classes, no visual change./groupsresult and extra pages: their plain empty message becomes the dashed placeholder, so the whole flow is consistent.Screenshots
The course result page needs the groups list from the backend, which is unreachable locally. Both before and after use the same temporary fixture: one course group, never committed.
Hub



Guide Generali


Course result


Verification
pnpm check,pnpm buildandpnpm typecheckpass.node --test tests/*.test.mjs: 3/3 pass./guidesroute was checked at 320, 390, 768, 1024, 1279, 1280, 1440, 1728 and 1920 px, with no horizontal overflow./groups/extra, the group result page,/faqs,/associationsand/projects.Trade-offs
/guides/corsonow walks three wizard steps to end on "Nessuna guida disponibile". This is honest, unlike the lorem it replaces, but it is still a dead end for the user. See the decision below.CardIcon's compact text width (240 px), which leaves air on the right at desktop widths. Widening it would change the shared size map.Deliberately left out / decisions needed
1921:4177) and a "Nuova Guida" editor on mobile. Which model to build, and who writes the content, is an open product/association decision (VISUAL_AUDIT §6), so nothing is built here./guidesstay reachable from the navigation, or be hidden? The code change for either option is trivial; the choice is not mine.Housekeeping
The screenshots live on
pr-assets/guides-visual-refinement, so this PR's diff stays code-only. That branch can be deleted after review.🤖 Generated with Claude Code