Skip to content

feat(guides): align the guides hub and pages, drop the lorem placeholders - #212

Merged
BIA3IA merged 2 commits into
feat/home-visual-refinementfrom
feat/guides-visual-refinement
Nov 2, 2026
Merged

BIA3IA merged 2 commits into
feat/home-visual-refinementfrom
feat/guides-visual-refinement

Conversation

@viganogabriele

Copy link
Copy Markdown
Contributor

Stacked on #211: feat/faqs-visual-refinement, the last layer of the stack that starts at #199. This is the last area of the page-by-page visual refinement: /guides, /guides/generali and /guides/corso/**. Figma frames: 1776:3073…1930:5103, mobile 3409:9532 / 3409:11418.

What changes

/guides hub

  • The page uses the shared container, rhythm and Hero of the other redesigned pages.
  • The hero gets Figma's subtitle, "Una raccolta di guide realizzate dai membri del Network". It is the Figma copy, not new content.
  • The two entry cards were centred flex items with different heights and offsets. They now sit in an equal-height grid: one column on phones, two from sm, capped at 896 px.
  • The cards are links but had no hover. They now use the same hover as every other link card.

/guides/generali and the course result page

  • Lorem ipsum removed: both pages served four lorem-ipsum guides, and they are live on beta today. The data is replaced with empty GENERAL_GUIDES / COURSE_GUIDES, so the pages show the empty state that was already in the code ("Nessuna guida disponibile al momento").
  • Shared empty state: it is drawn with the dashed placeholder used by projects, FAQ and associations.
  • Same layout as the group results: both pages now use the column and back/close header of the group result pages (feat(groups): fix the results layout and give every link a hover state #208), because they are the end of the same wizard.
  • Duplicate close button removed: on /guides/generali the back and close buttons both went to /guides, so only back remains.

/guides/corso wizard is unchanged: it shares WizardShell with /groups, already refined in #208. I re-checked it at every width.

Shared changes and their reach

Change Other pages affected
groups/page-header.tsx → layout/flow-header.tsx (FlowHeader, FLOW_MAIN), now used by groups and guides /groups/extra and the group result pages: on phones the top padding goes from 144 to 176 px. Before, the title sat 16 px under the fixed header pill. Desktop is unchanged.
EMPTY_STATE moved to layout/page.ts /projects, /associations, /faqs: identical classes, no visual change. /groups result and extra pages: their plain empty message becomes the dashed placeholder, so the whole flow is consistent.

Screenshots

The course result page needs the groups list from the backend, which is unreachable locally. Both before and after use the same temporary fixture: one course group, never committed.

Hub
hub 1440
hub 1024
hub 390

Guide Generali
generali 1440
generali 390

Course result
course 1440
course 390

Verification

  • pnpm check, pnpm build and pnpm typecheck pass.
  • node --test tests/*.test.mjs: 3/3 pass.
  • Every /guides route was checked at 320, 390, 768, 1024, 1279, 1280, 1440, 1728 and 1920 px, with no horizontal overflow.
  • Regression check at 390 and 1440 px on /groups/extra, the group result page, /faqs, /associations and /projects.

Trade-offs

  • Empty pages behind a working wizard. /guides/corso now walks three wizard steps to end on "Nessuna guida disponibile". This is honest, unlike the lorem it replaces, but it is still a dead end for the user. See the decision below.
  • Narrow card text. The hub cards keep CardIcon's compact text width (240 px), which leaves air on the right at desktop widths. Widening it would change the shared size map.

Deliberately left out / decisions needed

  • The guide model. Figma explores per-course articles with expandable sections (1921:4177) and a "Nuova Guida" editor on mobile. Which model to build, and who writes the content, is an open product/association decision (VISUAL_AUDIT §6), so nothing is built here.
  • Visibility of /guides (association). Until there is content, should /guides stay reachable from the navigation, or be hidden? The code change for either option is trivial; the choice is not mine.

Housekeeping

The screenshots live on pr-assets/guides-visual-refinement, so this PR's diff stays code-only. That branch can be deleted after review.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aa6e71fc-b87b-42cc-b778-1228e2eedf25

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@viganogabriele
viganogabriele marked this pull request as ready for review October 31, 2026 17:54
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from a56a7b3 to bd337e9 Compare November 2, 2026 13:53
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from f6f3d09 to cf40915 Compare November 2, 2026 13:53
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from bd337e9 to e3378e4 Compare November 2, 2026 14:06
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch 2 times, most recently from d29f2c1 to 08e4f52 Compare November 2, 2026 14:20
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from e3378e4 to 07c2fa0 Compare November 2, 2026 14:20
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from 08e4f52 to f1d4032 Compare November 2, 2026 14:32
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from 07c2fa0 to cc86268 Compare November 2, 2026 14:32
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from f1d4032 to 42217ac Compare November 2, 2026 14:35
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from cc86268 to 0411096 Compare November 2, 2026 14:35
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from 42217ac to aef988e Compare November 2, 2026 14:56
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from 0411096 to 29dadc5 Compare November 2, 2026 14:56
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from aef988e to b8450f6 Compare November 2, 2026 15:00
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch 2 times, most recently from d08ebb6 to 7827987 Compare November 2, 2026 15:02
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from b8450f6 to 5ce487d Compare November 2, 2026 15:02
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from 7827987 to 3f49e8b Compare November 2, 2026 15:14
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch 2 times, most recently from 1e7680c to 568b424 Compare November 2, 2026 15:19
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from 3f49e8b to 2d04118 Compare November 2, 2026 15:19
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from 568b424 to bb2a9f7 Compare November 2, 2026 15:26
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from 2d04118 to 49a9d5e Compare November 2, 2026 15:26
@BIA3IA
BIA3IA force-pushed the feat/faqs-visual-refinement branch from bb2a9f7 to bc1dc7f Compare November 2, 2026 15:28
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from 49a9d5e to df6552b Compare November 2, 2026 15:28
Base automatically changed from feat/faqs-visual-refinement to feat/home-visual-refinement November 2, 2026 16:02
…ders

- /guides uses the shared container, rhythm and Hero, with Figma's subtitle
  ("Una raccolta di guide realizzate dai membri del Network"); the two
  entry cards sit in an equal-height grid and react to hover, since they
  are links.
- /guides/generali and the course result page drop the lorem ipsum guides
  that were served in production and show their existing empty state
  instead. GENERAL_GUIDES / COURSE_GUIDES are empty until the guide model
  and content are decided.
- The back/close header and column of the wizard's end pages move from
  groups/page-header to layout/flow-header (FlowHeader, FLOW_MAIN), shared
  by groups and guides; the top padding on phones grows from 144 to 176px
  so the title no longer sits 16px under the fixed header.
- EMPTY_STATE (the dashed placeholder) moves to layout/page and is used by
  projects, associations, faqs, groups and guides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rses

- FLOW_COLUMN builds on CONTAINER, so wizard result pages get the 64px
  gutter from lg like every other page instead of 40px.
- The course step's empty list uses EMPTY_STATE, like the other lists
  this PR moved to it.
- Comments trimmed; project-list imports sorted.
@BIA3IA
BIA3IA force-pushed the feat/guides-visual-refinement branch from df6552b to b030678 Compare November 2, 2026 16:03
@BIA3IA
BIA3IA merged commit 7fd1b24 into feat/home-visual-refinement Nov 2, 2026
2 checks passed
@BIA3IA
BIA3IA deleted the feat/guides-visual-refinement branch November 2, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants