Skip to content

CI: Add RELEASE.md for trunklet-format release specifics - #1

Merged
jnasbyupgrade merged 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:release-md
Oct 26, 2026
Merged

jnasbyupgrade merged 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:release-md

Conversation

@jnasbyupgrade

@jnasbyupgrade jnasbyupgrade commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Adds RELEASE.md linking the shared release process plus the trunklet-format-specific points: releases 0.1, 0.1.0, 0.1.1 and 0.2.0 are branches, not tags (so don't create a same-named tag); and master sits on stable in both the control file and META.in.json.

Rebased onto current master (vendored pgxntool 2.4.0, stable adopted); RELEASE.md is the only file changed.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ac5b8777-368e-49f6-a3b9-3f3cd896df2c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jnasbyupgrade jnasbyupgrade changed the title Add RELEASE.md: pgxntool here creates branch, not tag CI: Add RELEASE.md for trunklet-format release specifics Oct 25, 2026
Comment thread RELEASE.md Outdated
- **No release has a tag yet.** `0.1`, `0.1.0`, `0.1.1` and `0.2.0` exist as branches on upstream. Where shared step 1 compares against the previous release's tag, use the `0.2.0` branch (or PGXN.org).
- **Never create a tag named like one of those branches.** The ref becomes ambiguous and `git push origin <version>` fails with `src refspec <version> matches more than one`.
- **Both `default_version` and `META.in.json` are `stable` on master.** `make post-tag-version-bump` resets only the control file; set the `version` fields in `META.in.json` back to `stable` by hand in the same commit (shared step 8).
- **The update script is `sql/trunklet-format--0.2.0--stable.sql`.** At release, `git mv` it to `sql/trunklet-format--0.2.0--<new-version>.sql`, then re-seed `sql/trunklet-format--<new-version>--stable.sql`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... why do we need to mention this? What's different here than standard process?

@jnasbyupgrade jnasbyupgrade Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude here: nothing — the shared process already covers the git mv and re-seed of the --stable update script, and the filename follows from its sql/<ext>--<last-released-version>--stable.sql pattern. Removed the bullet in f6dea07.

Comment thread RELEASE.md Outdated
- **Never create a tag named like one of those branches.** The ref becomes ambiguous and `git push origin <version>` fails with `src refspec <version> matches more than one`.
- **Both `default_version` and `META.in.json` are `stable` on master.** `make post-tag-version-bump` resets only the control file; set the `version` fields in `META.in.json` back to `stable` by hand in the same commit (shared step 8).
- **The update script is `sql/trunklet-format--0.2.0--stable.sql`.** At release, `git mv` it to `sql/trunklet-format--0.2.0--<new-version>.sql`, then re-seed `sql/trunklet-format--<new-version>--stable.sql`.
- **Before releasing, recheck the trunklet 0.2.0 wording in `HISTORY.asc` and `README.md`.** It says trunklet 0.2.0 has no update path and must be dropped and recreated; that stops being true once a trunklet release containing its `0.2.0--0.2.1` update script is on PGXN.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to release a corrected trunklet at the same time as trunklet-format. I believe that means this item can just go.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude here: removed that bullet in the amended commit (d2c61aa).

@jnasbyupgrade
jnasbyupgrade marked this pull request as ready for review October 26, 2026 22:57
@jnasbyupgrade
jnasbyupgrade merged commit 04390d8 into Postgres-Extensions:master Oct 26, 2026
4 checks passed
@jnasbyupgrade
jnasbyupgrade deleted the release-md branch October 26, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant