Repository navigation
Test2048 - #2065
Open
Aditya Patwardhan (adityapatwardhan) wants to merge 3 commits into
Open
Test2048#2065Aditya Patwardhan (adityapatwardhan) wants to merge 3 commits into
Aditya Patwardhan (adityapatwardhan) wants to merge 3 commits into
Conversation
Aditya Patwardhan (adityapatwardhan)
requested review from
Sydney Smith (SydneyhSmith),
alerickson,
Anam Navied (anamnavi) and
shammu1
as code owners
October 15, 2026 21:22
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
Wrong-scope deletion, inconsistent version matching, and failures for already-absent repositories remain unresolved.
3 open findings
What changed in this PR
This PR unifies DSC resource-state planning in PSResourceGet and expands regression coverage.
Changes:
- Shares action planning across get, test, set, and what-if operations.
- Updates scope/version handling and repository error reporting.
- Adds tests for desired-state checks, repeated operations, and resource discovery.
| File | Description |
|---|---|
| test/DscResource/PSResourceGetDSCResource.Tests.ps1 | Adds helpers and DSC regression tests. |
| src/dsc/psresourceget.ps1 | Centralizes action planning and updates operation handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| $allPSResources = @() | ||
| $name = $desiredResource.name | ||
| $matchingResources = @($installedResources | Where-Object { $_.name -eq $name }) |
| # Only remove the requested version (range) when there is one, otherwise all versions are removed | ||
| $versionParam = @{} | ||
| if ($_.desired.version) { | ||
| $versionParam['Version'] = $_.desired.version |
| if ($inputObj._exist -eq $false) { | ||
| Write-Trace -message "Repository $($inputObj.Name) exists and _exist is false. Deleting it." -level debug | ||
| Unregister-PSResourceRepository -Name $inputObj.Name | ||
| Unregister-PSResourceRepository -Name $inputObj.Name -ErrorAction Stop |
8 of 14 tasks
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
Copilot - review PR again |
Contributor
Re-reviewed the last three commits. The three earlier findings are fixed, but two issues remain:
Both changed PowerShell files parse successfully, and the whitespace check passed. DSC integration tests could not run locally because DSC is unavailable. Azure Pipelines reports macOS and Windows PowerShell failures, but its log endpoint was blocked here, so their causes remain unverified. No files changed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.